From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f182.google.com (mail-pg1-f182.google.com [209.85.215.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6387B19004A for ; Fri, 24 Oct 2025 05:07:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761282434; cv=none; b=FCWSVdFIkjlxyfwTEiO7AgplOLQ4BpSU1pht2GBbMtWaU9I5DWMYQJXCXYQkw5VJgCBKILDy2UKp5nXvXXj08K8RU7vApTpy7dUKR8p73gXiH/O+ozz0RO8qrJUYYIEy93ElrvQGTHf2wsZLXtHjihhpwQYrNMjNzGvcXBh/38E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761282434; c=relaxed/simple; bh=KOf5eTT11tPiB1wFmIqqQb2LaNMmdMl4equqT2XQSgo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=L1+X1yLVD9RZwIi8N1REEmn1olDzGkdWLUoJClogKTA2+KI+qONGdQx/ORqH0N9x0eNk9dy2bSPZWwjEJ3Pf/DE/7HNggjby8kqGMPOmPsdu0P/oohUNIgMU/BrLEZgwhP0lIqztsbXSaEmQeeq/ICIDy4fnmxOG5WBskzwyUI8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KrEj62U+; arc=none smtp.client-ip=209.85.215.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KrEj62U+" Received: by mail-pg1-f182.google.com with SMTP id 41be03b00d2f7-b6cf30e5bbcso1136099a12.0 for ; Thu, 23 Oct 2025 22:07:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761282433; x=1761887233; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=4dG92IcCVVEabZWYsVaYXSiYtILZo3vNbT6RrXxXUAA=; b=KrEj62U+wZCAW4o0pOqJ3kxshHA+YGyvNmEmi9+BTecmG32HaeA38Mi/UNkUstlQEQ ErApVwqZsVg2gFi36uwH6suFiTqt/F01iuQyCkLQnJK15icYyfhGhKQmX8EXL/mU2q7A /tgwmSrUG1O/6x99cqtbjA/Nho3+gSNNwY38qq3q+Sm9pqZyFEVrFBs2An4OPrg8PPvI +EBbH6iUVsakG0PoE8FlwkZs5xzqV2LJ1CRhR4luzD4kFT1xGmjJFPUkUwSU+zh/1XM1 nh0S2sFziglqDoXYYNY7QjpaIcvuw+oMuuNFtC68Bf3whNX4I8E9shCRnxyCiVx2tVay UY2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761282433; x=1761887233; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4dG92IcCVVEabZWYsVaYXSiYtILZo3vNbT6RrXxXUAA=; b=VRO/bbaGS2WjFs5j2v3EoQ6tJerk7zvx2+HiXOteLq0ipHkyR8X9l2b4q/rW3RWEpT 8FLF/IKMH/FQ1+uKwm7fHm4BUVJdbrd4D0g4ELzH4ITdVantjjtgZgXvA4q01ASHVSS0 fCk4fpeOK4YX4i+fy7H84ZzQql0v4JXp33HNF2vMRmG/NbvGVEKHmnOd6HifqLTzvEWX YnjRPOBKmyNKUhrgKCaqpaYfEvtbfmgD3FyMLX5w5o4TbfFMRHbroVUPPhzguvQX0Lu+ ounqx+MoR6Nc68uosKlaKbQx/VTYT1kTpKZ50uSLEAM9hmanbszYQXwLsaE2JPHLYkTw 3kEA== X-Forwarded-Encrypted: i=1; AJvYcCUmIi1J5tps/EEbaOK9xTrX05kaNpz/PaIzvBLeEaK9x45GjMY4S2QXPvFIbFDvUvi2X7paa/MAb5A=@vger.kernel.org X-Gm-Message-State: AOJu0Yyk9J72QNJ6CXoSD88WiIWywDXMbbK/+uGIDAFFMZ3qvEbKkZk+ Q1EiESdvnlVTcpUfodIWBHj1IRTCRJDoZs3PZY7J/qaF6eT+2kyHNvWK X-Gm-Gg: ASbGncv8DUuyBjISiXIjYSwrR2B5BeAUDTpIz8blRaAv2aUZOwR77Mh65epbdxWpnhB Gtc4Wmtiuj9hvI25Zb5q8m7Li86+s7OsxZDZksqSJIvKrTgH3E6HTfLJx+c/peYAihZnxw7eXS/ GY/5Dw+Wh096blRg7okTPhNGTu9WLCbWSSRCdDbLQMh0vXc1Tr/QszPRBXfnCK+edHeM3aO7bYt /6LmV60KOIkbVe5tkmLhjntWXwAksgpgAEjFe4U7rDyUlMiHjIcGurKyxS6LOIQc0mLdTm2BodQ 7k+zWbR5rx2qpeI9+4r21RNBiHRLeFzokTBOEHuqIKk9oUD9p2OuqvgefJTf75aMYbyhfSCiU6U OIpn1GLTV0CxtSEsMNXvscRCBDCJg9FJwW/gCzyyVUYKxMcdIhwAavrWFjD3vot3QQ6Sad3xEDU FcH5uxxhVl3mtfjtB+BpjJ0IcesrbUjzFb X-Google-Smtp-Source: AGHT+IGBgs2rmcQIySneHl58HLdSVRyoiObGynjzZrftZshrhpjwRJbzVvC89kZLGHBalw0a0P9C5w== X-Received: by 2002:a17:903:1ae3:b0:267:cdc1:83e with SMTP id d9443c01a7336-29489e10c88mr17625235ad.15.1761282432595; Thu, 23 Oct 2025 22:07:12 -0700 (PDT) Received: from [192.168.1.5] ([27.7.191.116]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2946e9dd105sm40716945ad.24.2025.10.23.22.07.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Oct 2025 22:07:12 -0700 (PDT) Message-ID: Date: Fri, 24 Oct 2025 10:37:06 +0530 Precedence: bulk X-Mailing-List: linux-mmc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 0/2] dt-bindings: mmc: ti,omap2430-sdhci: Add json schema for the text binding To: Rob Herring Cc: Ulf Hansson , Krzysztof Kozlowski , Conor Dooley , Paul Barker , Marc Murphy , Tony Lindgren , Kishon Vijay Abraham I , linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org References: <20251019-ti-sdhci-omap-v4-0-fdc63aaeb083@gmail.com> <20251020142710.GA576827-robh@kernel.org> <46aa84cd-63cc-4263-9061-021fa3205b87@gmail.com> <879da8d0-1ea5-4495-90e5-03b55aa91362@gmail.com> Content-Language: en-US From: Charan Pedumuru In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 23-10-2025 23:52, Rob Herring wrote: > On Thu, Oct 23, 2025 at 10:40 AM Charan Pedumuru > wrote: >> >> >> >> On 20-10-2025 21:28, Rob Herring wrote: >>> On Mon, Oct 20, 2025 at 10:44 AM Charan Pedumuru >>> wrote: >>>> >>>> >>>> >>>> On 20-10-2025 19:57, Rob Herring wrote: >>>>> On Sun, Oct 19, 2025 at 01:04:36PM +0000, Charan Pedumuru wrote: >>>>>> Create a YAML binding for ti,omap2430-sdhci and fix vmmc-supply >>>>>> property typo for a DTS file. >>>>>> >>>>>> Signed-off-by: Charan Pedumuru >>>>>> --- >>>>>> Note: The property "ti,needs-special-reset" was not removed from DTS cause it will >>>>>> disrupt the compilation for other compatibles as the node &mmc is used for all >>>>>> compatibles for some DTS files. >>>>> >>>>> I don't understand. AFIACT, "ti,needs-special-reset" is only used for >>>>> the hsmmc driver/binding. But this series for for the sdhci >>>>> driver/binding. So shouldn't the property be removed from sdhci nodes >>>>> (and the binding), but kept for hsmmc nodes? >>>> >>>> >>>> Yes we can remove that property from sdhci , but &mmc node in DTS is common for all mmc drivers and this "ti,needs-special-reset" property is defined there for one board, so even when I remove it from DTSI for sdhci nodes, the DTS file still contains this property in &mmc node which is also common for other mmc drivers, so even if we remove that property for sdhci node, we still need to define it in YAML to resolve dtb_check. The issue here is not removing the property from sdhci node in DTSI file, but to remove it from &mmc node from a DTS file which is common to all mmc drivers. >>>> >>>> Here is the DTS node (ti/omap/am5729-beagleboneai.dts) which contain that property and is common for all mmc drivers. >>>> &mmc2 { >>>> status = "okay"; >>>> vmmc-supply = <&vdd_1v8>; >>>> vqmmc-supply = <&vdd_1v8>; >>>> bus-width = <8>; >>>> ti,non-removable; >>>> non-removable; >>>> mmc-pwrseq = <&emmc_pwrseq>; >>>> >>>> ti,needs-special-reset; >>>> dmas = <&sdma_xbar 47>, <&sdma_xbar 48>; >>>> dma-names = "tx", "rx"; >>>> >>>> }; >>> >>> I'm pretty sure that's not how &mmc2 works and you are confused. I >>> would suggest you do a dtb->dts pass and compare the results. >> >> So, I can remove ti,needs-special-hs-handling and cap-mmc-dual-data-rate properties from a similar DTS file along with ti,needs-special-reset as these properties are not used for sdhci-omap driver and are no longer in use, I will remove these properties from YAML too, if this is true. Can you confirm this? > > If the properties are not used in drivers or .dts files, then yes they > don't need to be in the schema. > > I think you just need what you had previously and just drop the > changes to hsmmc nodes. Yes, I understood now, thanks for the clarification. > > Rob -- Best Regards, Charan.