From: Krzysztof Kozlowski <krzk@kernel.org>
To: Shan-Chun Hung <shanchun1218@gmail.com>,
ulf.hansson@linaro.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, adrian.hunter@intel.com,
p.zabel@pengutronix.de, pbrobinson@gmail.com, serghox@gmail.com,
mcgrof@kernel.org, prabhakar.mahadev-lad.rj@bp.renesas.com,
forbidden405@outlook.com, tmaimon77@gmail.com,
andy.shevchenko@gmail.com, linux-arm-kernel@lists.infradead.org,
linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: ychuang3@nuvoton.com, schung@nuvoton.com
Subject: Re: [PATCH v4 1/2] dt-bindings: mmc: nuvoton,ma35d1-sdhci: Document MA35D1 SDHCI controller
Date: Mon, 8 Jul 2024 16:19:11 +0200 [thread overview]
Message-ID: <d1422b93-b111-41f6-8537-a837a48e5743@kernel.org> (raw)
In-Reply-To: <20240704062623.1480062-2-shanchun1218@gmail.com>
On 04/07/2024 08:26, Shan-Chun Hung wrote:
> Add binding for Nuvoton MA35D1 SDHCI controller.
>
> Signed-off-by: Shan-Chun Hung <shanchun1218@gmail.com>
> ---
> +
> + nuvoton,sys:
> + $ref: /schemas/types.yaml#/definitions/phandle
> + description: phandle to access GCR (Global Control Register) registers.
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - clocks
> + - pinctrl-names
> + - pinctrl-0
> + - resets
> + - nuvoton,sys
Keep the same order as in list of properties.
Normally I would give conditional review tag, but not that case because
in the past you kept ignoring review comments.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-07-08 14:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-04 6:26 [PATCH v4 0/2] Add support for Nuvoton MA35D1 SDHCI Shan-Chun Hung
2024-07-04 6:26 ` [PATCH v4 1/2] dt-bindings: mmc: nuvoton,ma35d1-sdhci: Document MA35D1 SDHCI controller Shan-Chun Hung
2024-07-08 14:19 ` Krzysztof Kozlowski [this message]
2024-07-09 2:10 ` Shan-Chun Hung
2024-07-04 6:26 ` [PATCH v4 2/2] mmc: sdhci-of-ma35d1: Add Nuvoton MA35D1 SDHCI driver Shan-Chun Hung
2024-07-08 14:25 ` Krzysztof Kozlowski
2024-07-09 2:07 ` Shan-Chun Hung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d1422b93-b111-41f6-8537-a837a48e5743@kernel.org \
--to=krzk@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=forbidden405@outlook.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=pbrobinson@gmail.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=robh@kernel.org \
--cc=schung@nuvoton.com \
--cc=serghox@gmail.com \
--cc=shanchun1218@gmail.com \
--cc=tmaimon77@gmail.com \
--cc=ulf.hansson@linaro.org \
--cc=ychuang3@nuvoton.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox