From: Adrian Hunter <adrian.hunter@intel.com>
To: "Benoît Thébaudeau" <benoit@wsystem.com>,
linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org
Cc: "Ulf Hansson" <ulf.hansson@linaro.org>,
"Fabio Estevam" <fabio.estevam@nxp.com>,
joancarles <joancarles@fqingenieria.es>,
"Eric Bénard" <eric@eukrea.com>,
"Wolfram Sang" <wsa@the-dreams.de>
Subject: Re: [PATCH 1/4] mmc: sdhci-esdhc: Add SDHCI_QUIRK_32BIT_DMA_ADDR
Date: Mon, 29 May 2017 11:02:00 +0300 [thread overview]
Message-ID: <d70f8b0c-a17e-7cac-ff8e-227547ba0a4b@intel.com> (raw)
In-Reply-To: <1493805925-3644-1-git-send-email-benoit@wsystem.com>
On 03/05/17 13:05, Benoît Thébaudeau wrote:
> The eSDHC can only DMA from 32-bit-aligned addresses.
>
> This fixes the following test cases of mmc_test:
> 11: Badly aligned write
> 12: Badly aligned read
> 13: Badly aligned multi-block write
> 14: Badly aligned multi-block read
>
> Signed-off-by: Benoît Thébaudeau <benoit@wsystem.com>
I would expect to see Acks from other sdhci-esdhc users. Nevertheless for
sdhci:
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> drivers/mmc/host/sdhci-esdhc.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mmc/host/sdhci-esdhc.h b/drivers/mmc/host/sdhci-esdhc.h
> index c4bbd74..e7893f2 100644
> --- a/drivers/mmc/host/sdhci-esdhc.h
> +++ b/drivers/mmc/host/sdhci-esdhc.h
> @@ -19,6 +19,7 @@
> */
>
> #define ESDHC_DEFAULT_QUIRKS (SDHCI_QUIRK_FORCE_BLK_SZ_2048 | \
> + SDHCI_QUIRK_32BIT_DMA_ADDR | \
> SDHCI_QUIRK_NO_BUSY_IRQ | \
> SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK | \
> SDHCI_QUIRK_PIO_NEEDS_DELAY | \
>
next prev parent reply other threads:[~2017-05-29 8:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-03 10:05 [PATCH 1/4] mmc: sdhci-esdhc: Add SDHCI_QUIRK_32BIT_DMA_ADDR Benoît Thébaudeau
2017-05-03 10:05 ` [PATCH 2/4] mmc: sdhci-esdhc-imx: Fix DAT line software reset Benoît Thébaudeau
2017-05-29 8:02 ` Adrian Hunter
2017-05-29 11:13 ` Fabio Estevam
2017-05-03 10:05 ` [PATCH 3/4] mmc: sdhci-esdhc-imx: Allow all supported prescaler values Benoît Thébaudeau
2017-05-29 8:03 ` Adrian Hunter
2017-05-29 11:14 ` Fabio Estevam
2017-05-03 10:05 ` [PATCH 4/4] mmc: sdhci-esdhc-imx: Remove the ENGcm07207 workaround Benoît Thébaudeau
2017-05-29 8:07 ` Adrian Hunter
2017-05-29 14:42 ` Ulf Hansson
2017-05-29 16:39 ` Benoît Thébaudeau
2017-05-29 11:14 ` Fabio Estevam
2017-05-04 8:47 ` [PATCH 1/4] mmc: sdhci-esdhc: Add SDHCI_QUIRK_32BIT_DMA_ADDR Arnd Bergmann
2017-05-04 9:00 ` Benoît Thébaudeau
2017-05-04 9:37 ` Arnd Bergmann
2017-05-29 8:02 ` Adrian Hunter [this message]
2017-05-29 11:12 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d70f8b0c-a17e-7cac-ff8e-227547ba0a4b@intel.com \
--to=adrian.hunter@intel.com \
--cc=benoit@wsystem.com \
--cc=eric@eukrea.com \
--cc=fabio.estevam@nxp.com \
--cc=joancarles@fqingenieria.es \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox