From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76BEBC433F5 for ; Thu, 19 May 2022 11:18:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233007AbiESLSo (ORCPT ); Thu, 19 May 2022 07:18:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60246 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230008AbiESLSn (ORCPT ); Thu, 19 May 2022 07:18:43 -0400 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EB73AA501D; Thu, 19 May 2022 04:18:40 -0700 (PDT) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: kholk11) with ESMTPSA id 294EA1F45A60 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1652959119; bh=8hHuB3iHrcQC4fZoJfLi8hVlnXkttGVOtI+EU+Ln4bY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=kNIuRzKxMhgD6upJLoGW4KXkvrPyPPNaTjtKrzGhVwZ4+O5k1tWYP5R6kRZ+IYT+J +atXn1qrvnV2JlvB0+3tGpNwpFnt9fQSoOUVzuLRYLHZzrvmccL4/8bRhc6UCaZaah V+lOKHmNH0nafJ4RlygrDiu1Kt8eC1b1tmkwSreJs4sFZ4VjHkEio+SftcbeswhHF+ akrlMLbeNQH8eC0AR1pzL4Drni98XU7Ki00K7QqDEYQLWqPpvbeflCMGwi+pRRbyiA UgPGV44+4ccNcANnHzuo8BHoV6evaHbLu+EQYtPewZQfaV37MZEljFs/Of5SfxIpFA FTa0rCBgWVigw== Message-ID: Date: Thu, 19 May 2022 13:18:35 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v10 1/3] dt-bindings: mmc: mtk-sd: extend interrupts and pinctrls properties Content-Language: en-US To: Axe Yang , Ulf Hansson , Rob Herring , Chaotian Jing , Matthias Brugger , Adrian Hunter Cc: Yoshihiro Shimoda , Satya Tangirala , Andy Shevchenko , Wolfram Sang , Lucas Stach , Eric Biggers , Andrew Jeffery , Stephen Boyd , Kiwoong Kim , Yue Hu , Tian Tao , linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com References: <20220519111323.14586-1-axe.yang@mediatek.com> <20220519111323.14586-2-axe.yang@mediatek.com> From: AngeloGioacchino Del Regno In-Reply-To: <20220519111323.14586-2-axe.yang@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org Il 19/05/22 13:13, Axe Yang ha scritto: > Extend interrupts and pinctrls for SDIO wakeup interrupt feature. > This feature allow SDIO devices alarm asynchronous interrupt to host > even when host stop providing clock to SDIO card. An extra wakeup > interrupt and pinctrl states for SDIO DAT1 pin state switching are > required in this scenario. > > Signed-off-by: Axe Yang > --- > .../devicetree/bindings/mmc/mtk-sd.yaml | 53 ++++++++++++++++++- > 1 file changed, 52 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml > index 2a2e9fa8c188..b068ab67a054 100644 > --- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml > +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml > @@ -72,12 +72,26 @@ properties: > - const: ahb_cg > > interrupts: > - maxItems: 1 > + description: > + Should at least contain MSDC GIC interrupt. To support SDIO in-band wakeup, an extended > + interrupt is required and be configured as wakeup source irq. > + minItems: 1 > + maxItems: 2 > + > + interrupt-names: > + items: > + - const: msdc_irq > That ain't right. You have two interrupts, so you describe two interrupts: interrupt-names: minItems: 1 items: - const: msdc - const: sdio-wakeup ...also, I personally don't like the "_irq" suffix: we're specifying interrupts in interrupt-names, so it sounds a bit redundant. You're free to keep it, if you really like it though. Regards, Angelo