From: Heiner Kallweit <hkallweit1@gmail.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Carlo Caione <carlo@caione.org>,
Kevin Hilman <khilman@baylibre.com>,
linux-mmc@vger.kernel.org
Subject: [PATCH 8/9] mmc: meson-gx: remove unneeded checks in remove
Date: Tue, 31 Jan 2017 21:58:57 +0100 [thread overview]
Message-ID: <db91ad1d-7291-0282-d9a6-14498c608cc2@gmail.com> (raw)
In-Reply-To: <24e8bf35-50ce-270d-c0aa-12bb90d2e3d8@gmail.com>
The remove callback is called only if probe finished successfully.
Therefore these checks are not needed.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/mmc/host/meson-gx-mmc.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
index 48ce4ba4..bc787444 100644
--- a/drivers/mmc/host/meson-gx-mmc.c
+++ b/drivers/mmc/host/meson-gx-mmc.c
@@ -811,15 +811,11 @@ static int meson_mmc_remove(struct platform_device *pdev)
{
struct meson_host *host = dev_get_drvdata(&pdev->dev);
- if (WARN_ON(!host))
- return 0;
-
/* disable interrupts */
writel(0, host->regs + SD_EMMC_IRQ_EN);
- if (host->bounce_buf)
- dma_free_coherent(host->dev, host->bounce_buf_size,
- host->bounce_buf, host->bounce_dma_addr);
+ dma_free_coherent(host->dev, host->bounce_buf_size,
+ host->bounce_buf, host->bounce_dma_addr);
clk_disable_unprepare(host->cfg_div_clk);
clk_disable_unprepare(host->core_clk);
--
2.11.0
next prev parent reply other threads:[~2017-01-31 21:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <24e8bf35-50ce-270d-c0aa-12bb90d2e3d8@gmail.com>
2017-01-31 20:57 ` [PATCH 2/9] mmc: meson-gx: minor improvements in meson_mmc_set_ios Heiner Kallweit
2017-02-01 11:55 ` Jaehoon Chung
2017-02-01 20:16 ` Heiner Kallweit
2017-02-03 13:52 ` Kevin Hilman
2017-01-31 20:58 ` [PATCH 3/9] mmc: meson-gx: improve meson_mmc_clk_set Heiner Kallweit
2017-02-01 12:24 ` Jaehoon Chung
2017-02-01 20:29 ` Heiner Kallweit
2017-02-02 9:09 ` Ulf Hansson
2017-01-31 20:58 ` [PATCH 4/9] mmc: meson-gx: improve meson_mmc_irq_thread Heiner Kallweit
2017-01-31 20:58 ` [PATCH 5/9] mmc: meson-gx: improve interrupt handling Heiner Kallweit
2017-01-31 20:58 ` [PATCH 6/9] mmc: meson-gx: set max block count and request size Heiner Kallweit
2017-01-31 20:58 ` [PATCH 7/9] mmc: meson-gx: reduce bounce buffer size Heiner Kallweit
2017-01-31 20:58 ` Heiner Kallweit [this message]
2017-01-31 20:59 ` [PATCH 9/9] mmc: meson-gx: add support for HS400 mode Heiner Kallweit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db91ad1d-7291-0282-d9a6-14498c608cc2@gmail.com \
--to=hkallweit1@gmail.com \
--cc=carlo@caione.org \
--cc=khilman@baylibre.com \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox