From: Daniel Kucera <linux-mmc@danman.eu>
To: Avri Altman <Avri.Altman@wdc.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>, linux-mmc@vger.kernel.org
Subject: Re: [PATCH v4] mmc: core: allow detection of locked cards
Date: Wed, 10 Jul 2024 07:21:40 +0200 [thread overview]
Message-ID: <dc3524328a701be1ac3206af24b4a185@danman.eu> (raw)
In-Reply-To: <DM6PR04MB65756BE6093A5173C58CE9E4FCDB2@DM6PR04MB6575.namprd04.prod.outlook.com>
On 2024-07-09 22:06, Avri Altman wrote:
>> If I understand correctly, there is no point in sending the CMD13
>> above, unless
>> this is the first attempt to initialize the card.
>> Therefore, it's better to move the whole part above, inside the below
>> if-clause
>> too, otherwise we would end up sending a CMD13 in cases when it's not
>> needed.
> R1_CARD_IS_LOCKED is CMD13 response, but already in CMD7 response as
> well,
> So theoretically you want to skip mmc_sd_setup_card altogether.
Do you mean to modify:
mmc_select_card(struct mmc_card *card)
to somehow return or save the R1 response to card struct?
Because currently, it is not available.
Thank you,
Daniel.
> ACMD6, CMD6, and CMD19 should wait for CMD42 to unlock the card.
>
> Thanks,
> Avri
>
>>
>> > +
>> > + if (!reinit && !(card_status & R1_CARD_IS_LOCKED)) {
>> > /*
>> > * Fetch SCR from card.
>> > */
>> > --
>> > 2.34.1
>> >
>>
>> Kind regards
>> Uffe
next prev parent reply other threads:[~2024-07-10 5:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-06 13:12 [PATCH v4] mmc: core: allow detection of locked cards linux-mmc
2024-06-20 12:38 ` Ulf Hansson
2024-06-20 12:59 ` Daniel Kucera
2024-06-20 14:32 ` Ulf Hansson
2024-06-20 15:31 ` Christian Loehle
2024-06-20 18:15 ` Daniel Kucera
2024-06-21 7:16 ` Avri Altman
2024-07-01 8:33 ` Daniel Kucera
2024-07-08 13:32 ` Ulf Hansson
2024-07-08 13:43 ` Ulf Hansson
2024-07-09 20:06 ` Avri Altman
2024-07-10 5:21 ` Daniel Kucera [this message]
2024-07-10 5:49 ` Avri Altman
2024-07-10 13:26 ` Ulf Hansson
2024-07-13 20:50 ` Daniel Kucera
2024-07-14 6:49 ` Avri Altman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc3524328a701be1ac3206af24b4a185@danman.eu \
--to=linux-mmc@danman.eu \
--cc=Avri.Altman@wdc.com \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox