From mboxrd@z Thu Jan 1 00:00:00 1970 From: merez@codeaurora.org Subject: Re: [PATCH v9] mmc: support BKOPS feature for eMMC Date: Tue, 12 Jun 2012 03:58:36 -0700 (PDT) Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT Return-path: Received: from wolverine02.qualcomm.com ([199.106.114.251]:1614 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752360Ab2FLK6g (ORCPT ); Tue, 12 Jun 2012 06:58:36 -0400 Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Jaehoon Chung Cc: linux-mmc , Chris Ball , Kyungmin Park , Hanumath Prasad , Per FORLIN , Sebastian Rasmussen , "Dong, Chuanxiao" , "svenkatr@ti.com" , Saugata Das , Konstantin Dorfman , Adrian Hunter , Maya Erez , Ulf Hansson > @@ -359,12 +443,15 @@ struct mmc_async_req *mmc_start_req(struct mmc_host > *host, > if (!err && areq) > start_err = __mmc_start_req(host, areq->mrq); > > - if (host->areq) > + if (host->areq) { > + if (!areq && host->areq && mmc_card_mmc(host->card)) > + mmc_start_bkops(host->card); I think it would be better to start tey BKOPs in the queue thread when it becomes idle. We have seen cases where there are several requests fetched and then NULL but by the time the previous request ends there are more requests to be fetched. Starting the BKOPs here instead of in the queue thread increases the probability of using HPI to stop the BKOPs due to incoming request, which is not a desirable action. > mmc_post_req(host, host->areq->mrq, 0); > + } > > /* Cancel a prepared request if it was not started. */ > if ((err || start_err) && areq) > - mmc_post_req(host, areq->mrq, -EINVAL); > + mmc_post_req(host, areq->mrq, -EINVAL); Remove this change, it is not related to this patch. Thanks, Maya Erez Consultant for Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum