From: Christian Loehle <christian.loehle@arm.com>
To: Bart Van Assche <bvanassche@acm.org>, Qais Yousef <qyousef@layalina.io>
Cc: linux-kernel@vger.kernel.org, peterz@infradead.org,
juri.lelli@redhat.com, mingo@redhat.com, rafael@kernel.org,
dietmar.eggemann@arm.com, vschneid@redhat.com,
vincent.guittot@linaro.org, Johannes.Thumshirn@wdc.com,
adrian.hunter@intel.com, ulf.hansson@linaro.org,
andres@anarazel.de, asml.silence@gmail.com,
linux-pm@vger.kernel.org, linux-block@vger.kernel.org,
io-uring@vger.kernel.org, linux-mmc@vger.kernel.org
Subject: Re: [RFC PATCH 0/2] Introduce per-task io utilization boost
Date: Mon, 25 Mar 2024 12:06:16 +0000 [thread overview]
Message-ID: <de1eba3c-2453-4c5c-bd80-dd7d7b33f60d@arm.com> (raw)
In-Reply-To: <2ed2dadc-bdc4-4a21-8aca-a2aac0c6479a@acm.org>
On 21/03/2024 19:52, Bart Van Assche wrote:
> On 3/21/24 10:57, Christian Loehle wrote:
>> In the long-term it looks like for UFS the problem will disappear as we are
>> expected to get one queue/hardirq per CPU (as Bart mentioned), on NVMe that
>> is already the case.
>
> Why the focus on storage controllers with a single completion interrupt?
> It probably won't take long (one year?) until all new high-end
> smartphones may have support for multiple completion interrupts.
>
> Thanks,
>
> Bart.
>
Apart from going to "This patch shows significant performance improvements on
hardware that runs mainline today" to "This patch will have significant
performance improvements on devices running mainline in a couple years"
nothing in particular.
I'm fine with leaving it with having acknowledged the problem.
Maybe I would just gate the task placement on the task having been in
UFS (with multiple completion interrupts) or NVMe submission recently to
avoid regressions to current behavior in future versions. I did have that
already at some point, although it was a bit hacky.
Anyway, thank you for your input on that, it is what I wanted to hear!
Kind Regards,
Christian
next prev parent reply other threads:[~2024-03-25 12:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240304201625.100619-1-christian.loehle@arm.com>
[not found] ` <86f0af00-8765-4481-9245-1819fb2c6379@acm.org>
[not found] ` <0dc6a839-2922-40ac-8854-2884196da9b9@arm.com>
[not found] ` <c5b7fc1f-f233-4d25-952b-539607c2a0cc@acm.org>
[not found] ` <2784c093-eea1-4b73-87da-1a45f14013c8@arm.com>
[not found] ` <20240321123935.zqscwi2aom7lfhts@airbuntu>
2024-03-21 17:57 ` [RFC PATCH 0/2] Introduce per-task io utilization boost Christian Loehle
2024-03-21 19:52 ` Bart Van Assche
2024-03-25 12:06 ` Christian Loehle [this message]
2024-03-25 17:23 ` Bart Van Assche
2024-03-25 2:53 ` Qais Yousef
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=de1eba3c-2453-4c5c-bd80-dd7d7b33f60d@arm.com \
--to=christian.loehle@arm.com \
--cc=Johannes.Thumshirn@wdc.com \
--cc=adrian.hunter@intel.com \
--cc=andres@anarazel.de \
--cc=asml.silence@gmail.com \
--cc=bvanassche@acm.org \
--cc=dietmar.eggemann@arm.com \
--cc=io-uring@vger.kernel.org \
--cc=juri.lelli@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=qyousef@layalina.io \
--cc=rafael@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox