Re: [PATCH 17/34] mmc: sdhci-of-arasan: Drop the use of sdhci_pltfm_free()

[Michal Simek <michal.simek@amd.com>]

On 5/26/25 08:06, Binbin Zhou wrote:
> Since the devm_mmc_alloc_host() helper is already in
> use, sdhci_pltfm_free() is no longer needed.
> 
> Cc: Michal Simek <michal.simek@amd.com>
> Signed-off-by: Binbin Zhou <zhoubinbin@loongson.cn>
> ---
>   drivers/mmc/host/sdhci-of-arasan.c | 26 ++++++++------------------
>   1 file changed, 8 insertions(+), 18 deletions(-)
> 
> diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c
> index 8c29676ab662..42878474e56e 100644
> --- a/drivers/mmc/host/sdhci-of-arasan.c
> +++ b/drivers/mmc/host/sdhci-of-arasan.c
> @@ -1883,34 +1883,26 @@ static int sdhci_arasan_probe(struct platform_device *pdev)
>   		sdhci_arasan->soc_ctl_base = syscon_node_to_regmap(node);
>   		of_node_put(node);
>   
> -		if (IS_ERR(sdhci_arasan->soc_ctl_base)) {
> -			ret = dev_err_probe(dev,
> +		if (IS_ERR(sdhci_arasan->soc_ctl_base))
> +			return dev_err_probe(dev,
>   					    PTR_ERR(sdhci_arasan->soc_ctl_base),
>   					    "Can't get syscon\n");
> -			goto err_pltfm_free;
> -		}
>   	}
>   
>   	sdhci_get_of_property(pdev);
>   
>   	sdhci_arasan->clk_ahb = devm_clk_get(dev, "clk_ahb");
> -	if (IS_ERR(sdhci_arasan->clk_ahb)) {
> -		ret = dev_err_probe(dev, PTR_ERR(sdhci_arasan->clk_ahb),
> +	if (IS_ERR(sdhci_arasan->clk_ahb))
> +		return dev_err_probe(dev, PTR_ERR(sdhci_arasan->clk_ahb),
>   				    "clk_ahb clock not found.\n");
> -		goto err_pltfm_free;
> -	}
>   
>   	clk_xin = devm_clk_get(dev, "clk_xin");
> -	if (IS_ERR(clk_xin)) {
> -		ret = dev_err_probe(dev, PTR_ERR(clk_xin), "clk_xin clock not found.\n");
> -		goto err_pltfm_free;
> -	}
> +	if (IS_ERR(clk_xin))
> +		return dev_err_probe(dev, PTR_ERR(clk_xin), "clk_xin clock not found.\n");
>   
>   	ret = clk_prepare_enable(sdhci_arasan->clk_ahb);
> -	if (ret) {
> -		dev_err(dev, "Unable to enable AHB clock.\n");
> -		goto err_pltfm_free;
> -	}
> +	if (ret)
> +		return dev_err_probe(dev, ret, "Unable to enable AHB clock.\n");
>   
>   	/* If clock-frequency property is set, use the provided value */
>   	if (pltfm_host->clock &&
> @@ -2029,8 +2021,6 @@ static int sdhci_arasan_probe(struct platform_device *pdev)
>   	clk_disable_unprepare(clk_xin);
>   clk_dis_ahb:
>   	clk_disable_unprepare(sdhci_arasan->clk_ahb);
> -err_pltfm_free:
> -	sdhci_pltfm_free(pdev);
>   	return ret;
>   }
>   

I don't have problem with this change but your series is just wrong. Because
"mmc: sdhci-pltfm: Drop the use of sdhci_pltfm_free()"
is just removing this function before you convert all drivers. It means you just 
break bisectability of tree which is clear NACK.

Thanks,
Michal