From: Krzysztof Kozlowski <krzk@kernel.org>
To: Shan-Chun Hung <shanchun1218@gmail.com>,
ulf.hansson@linaro.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, adrian.hunter@intel.com,
p.zabel@pengutronix.de, pbrobinson@gmail.com, serghox@gmail.com,
mcgrof@kernel.org, prabhakar.mahadev-lad.rj@bp.renesas.com,
forbidden405@outlook.com, tmaimon77@gmail.com,
andy.shevchenko@gmail.com, linux-arm-kernel@lists.infradead.org,
linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: ychuang3@nuvoton.com, schung@nuvoton.com
Subject: Re: [PATCH v3 1/2] dt-bindings: mmc: nuvoton,ma35d1-sdhci: Document MA35D1 SDHCI controller
Date: Mon, 1 Jul 2024 07:58:04 +0200 [thread overview]
Message-ID: <e02dc084-1e69-4231-b191-3605c68b53f4@kernel.org> (raw)
In-Reply-To: <20240701003913.729428-2-shanchun1218@gmail.com>
On 01/07/2024 02:39, Shan-Chun Hung wrote:
> Add binding for Nuvoton MA35D1 SDHCI controller.
>
> Signed-off-by: Shan-Chun Hung <shanchun1218@gmail.com>
You ignored comment third time.
NAK.
<form letter>
This is a friendly reminder during the review process.
It seems my or other reviewer's previous comments were not fully
addressed. Maybe the feedback got lost between the quotes, maybe you
just forgot to apply it. Please go back to the previous discussion and
either implement all requested changes or keep discussing them.
Thank you.
</form letter>
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-07-01 5:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-01 0:39 [PATCH v3 0/2] Add support for Nuvoton MA35D1 SDHCI Shan-Chun Hung
2024-07-01 0:39 ` [PATCH v3 1/2] dt-bindings: mmc: nuvoton,ma35d1-sdhci: Document MA35D1 SDHCI controller Shan-Chun Hung
2024-07-01 5:58 ` Krzysztof Kozlowski [this message]
2024-07-01 6:56 ` Shan-Chun Hung
2024-07-01 0:39 ` [PATCH v3 2/2] mmc: sdhci-of-ma35d1: Add Nuvoton MA35D1 SDHCI driver Shan-Chun Hung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e02dc084-1e69-4231-b191-3605c68b53f4@kernel.org \
--to=krzk@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=forbidden405@outlook.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=pbrobinson@gmail.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=robh@kernel.org \
--cc=schung@nuvoton.com \
--cc=serghox@gmail.com \
--cc=shanchun1218@gmail.com \
--cc=tmaimon77@gmail.com \
--cc=ulf.hansson@linaro.org \
--cc=ychuang3@nuvoton.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox