From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C31601F7554 for ; Wed, 23 Apr 2025 12:18:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745410703; cv=none; b=Ia0jX4pOY+XQWLoVwumRkC1Cn3HXhFOEOOJahgSMsaoFPCTLXXxxvfNYSMdyWkVl1EQrHRjziCCrUOLkBkRM3mvKKLOZ0tX7zTOQWoZgwqYvm4ZHXZzCiJypj7nHIds3uxrFsFbP9H8Lhe+lmy1mDGeoOIk8q+vdB6hFsbqMUWU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745410703; c=relaxed/simple; bh=tCHjkL1SLgoL2j2PMqkiNHKmGBzODwMfabfskxgGLgY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=umVEKaSle5Yg/y58tvtx0RZRN/vGPreeHqUL9jZrRqvT9ajuz+92RfWqiC704suN12QvW54F3MW7a3yMkxdm+Za1vpCUMau7iBuvV0ieY4Jd+PUPnrGDYcBSSkIK3+CscMI/pGzd1UKXv0/PNgp5vlADFBruivXHZpEv1aLZ750= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Si+5gSsH; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Si+5gSsH" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 53NAZmDX003044 for ; Wed, 23 Apr 2025 12:18:18 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ioGfs5MtgxexvBjcj4mXKq9ldJm50YBOXelQWnDDA+w=; b=Si+5gSsH5Sq4CR5G Zobx6D0+awRftNyIeqLD7wIQskcuztJErV9gBIQp2+U6xijczIIGrGoV3uMuvabf cR2Xq8lPy7e8jzNEHDBW+Og4hF5TZymj9fK/dEZzsIqvbifYODTJbgyUohcQ64+u 0X4uPBqGFeeHEAdZ5+1hXskww8AEFCL86Squ1tM1exBkLb5iGs0PXfZdkADjR3M6 xq1FhOyRQWGM1oeaQTo0L0a/yBRvylt0hKZKgfCANbK3gwS0ayoj1gl7bPDuhqPG LxAOgDlMO66Wd5eF2yvBd/PwJx6SGqzIu3vcrZc2MrGFEWvmTNoGel42tBrLw6u7 lJVAvQ== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 466jgy22m7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Wed, 23 Apr 2025 12:18:18 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-7c555d4ad75so31768385a.0 for ; Wed, 23 Apr 2025 05:18:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745410697; x=1746015497; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ioGfs5MtgxexvBjcj4mXKq9ldJm50YBOXelQWnDDA+w=; b=RrgExIfZN/3Bhsea9JUmXLpxVpPZggucIuddC+7er4QuzeURL8gRj9p6/2Q6fVTNsq nN+8C49b7XkLEqzfgJy++gFy3tlawd8Ur+sJZJ1A8xb1gg9XNxn+Bnb8JXX7c9s7Nemf PZNGdpjK0ml/5z52kKHefhbkeI9bf82T+U3IT+OW3YIRyRdStSasMd4RCnvUN/U/uvSk Y0PopgTDKXYPe+dPJhAgJeV81iN27JzzDLk0XzJx4P4XyV1NmrOtZfdBp4N/4F6EbBKD HfBjepSfMcgeUvp5IoCBvJivI2KoAuNdLQfBWOlN5ONqr0x4M8vGQEFI7Qryfzffj4Rz JNIA== X-Forwarded-Encrypted: i=1; AJvYcCV33xheteuA02XtKO7O5zxI7jIaLylfdSHIeL0RsGwwFVb3xH+0BJvyk0dS+IrijHO6vY+uDygj+N4=@vger.kernel.org X-Gm-Message-State: AOJu0Yzn31nAgautR6gi4feGhBDV6oMUH3boMGuDPiudfGFpOc/5L6c4 ix/v0g9HysDWbhQ5adyjIML1Xy1fJeeFBI259l1QjjH3AvucBVBnCfEhYMA52K6oqwdIZJGewA3 voEMWchGA4iPluDM2bp1xctOnuUGVkuqlGinic02XRmaPzxdudde7rQht0DE= X-Gm-Gg: ASbGnctku7bwCAQKAxgadZSkTqbPLjWjpp/v5V4onG83Nb3AgFomxfbMcseh6zkrP7H C7SKD8+FncgSCBJHrcoB49YHPsFFc/J7f2j3WNuMKv+PgSk5gTGs2oVAVTRLiTuDnBhB2BKQtci qu9zG48zq1d7Wnpn/JuieLbXO/IoFJgKU3Obb4rIL6UG2D1Q4PewdP2AQWzX1O/xekDSJF5pFeQ Zak1hQB1pXPAX4n4dOSmZcLKeo74gLdNTjuPp/Im+LcQIRIHGRFFcPWPELhSs72fcUsdco+gLzd GiUQtbgdV4KEnKqpUrEtCJpv9x9lVXRM+qQu2vmd8+3TgAbji+F/ncfI6OnQ1nwEYiM= X-Received: by 2002:a05:620a:2492:b0:7c0:be0e:cb09 with SMTP id af79cd13be357-7c94d266c35mr148950785a.7.1745410697583; Wed, 23 Apr 2025 05:18:17 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEav1ZFFMWH2+h22EnPEjP1DswVCKNGIgBpCwJp2VazcB6M7t8R/W/1xgUW9/XgzClpBqzW6A== X-Received: by 2002:a05:620a:2492:b0:7c0:be0e:cb09 with SMTP id af79cd13be357-7c94d266c35mr148944985a.7.1745410697019; Wed, 23 Apr 2025 05:18:17 -0700 (PDT) Received: from [192.168.65.183] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-acb6efadd51sm817256866b.179.2025.04.23.05.18.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Apr 2025 05:18:16 -0700 (PDT) Message-ID: Date: Wed, 23 Apr 2025 14:18:05 +0200 Precedence: bulk X-Mailing-List: linux-mmc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 30/33] arm64: dts: qcom: Add dtsi for Snapdragon 730/730g/732g (SM7150) SoCs To: Danila Tikhonov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Lorenzo Pieralisi , "Rafael J . Wysocki" , Viresh Kumar , Manivannan Sadhasivam , Wim Van Sebroeck , Guenter Roeck , Rajendra Nayak , Jassi Brar , Bjorn Andersson , Konrad Dybcio , Amit Kucheria , Thara Gopinath , Daniel Lezcano , Zhang Rui , Lukasz Luba , Thomas Gleixner , Greg Kroah-Hartman , Wesley Cheng , Vinod Koul , Kishon Vijay Abraham I , Ulf Hansson , Souradeep Chowdhury , Lee Jones , Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alex Elder , Alim Akhtar , Avri Altman , Bart Van Assche , Andy Gross , Srinivas Kandagatla , Herbert Xu , Krzysztof Kozlowski , Georgi Djakov , Loic Poulain , Robert Foss , Andi Shyti , Michael Turquette , Stephen Boyd , Taniya Das , Sibi Sankar , Will Deacon , Robin Murphy , Joerg Roedel , Imran Shaik , Mathieu Poirier , Bartosz Golaszewski , Neil Armstrong , Jessica Zhang , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Kees Cook , Tony Luck , "Guilherme G . Piccoli" , David Wronek , Jens Reidel Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-usb@vger.kernel.org, linux-phy@lists.infradead.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-scsi@vger.kernel.org, dmaengine@vger.kernel.org, linux-crypto@vger.kernel.org, linux-i2c@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, linux-remoteproc@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-hardening@vger.kernel.org, linux@mainlining.org, ~postmarketos/upstreaming@lists.sr.ht References: <20250422213137.80366-1-danila@jiaxyga.com> <20250422213137.80366-14-danila@jiaxyga.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20250422213137.80366-14-danila@jiaxyga.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNDIzMDA4NCBTYWx0ZWRfX7cWy9VJwWA7o CCeiVl4rtt+VbWQnoKrzn5gdMZ2MWJAWXEcjC+IbJ+aknQs5nK1fCT+WiW4hhUkLdj96Gb9PtIx 7tyF6uMuw196q1o8o+XOy08vH3rw7hM59iBvPc+Cdz0dPMpfgtGG8iPNCyVyioUGRL8W7uxiZAV 0PbsdpHpafmoYCVlNBqdW+j9q7vzFms7LA/kb9FqfepSziqI24WJCOosW9WG6xyMKn58M8Xy54q pEkGBqNkYzlEHYpgwoL7xtOk8UU6nBA5b05P8Rv86RNUuHvcD71qfEVPVkLke/d1AeCkGVcwjcl iWOP/qpTdIUfpyTlwysFF674FubnGiACtYvUL/eqB40xglJ8sNwFGCeAdK8AwuI/+DETY/mx36R P8ciqUEpUOTe2gwmB1ZKS6H9GgUXZI2aOmBmD/bK37niOjovdqIwNoflXipUSwKWrEsSy4M+ X-Proofpoint-GUID: YldNJi4riHJ7vv1sT_d7aK_jDnkh0cAv X-Proofpoint-ORIG-GUID: YldNJi4riHJ7vv1sT_d7aK_jDnkh0cAv X-Authority-Analysis: v=2.4 cv=M5VNKzws c=1 sm=1 tr=0 ts=6808da8a cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=XR8D0OoHHMoA:10 a=VwQbUJbxAAAA:8 a=KKAkSRfTAAAA:8 a=OuZLqq7tAAAA:8 a=7ibcVnAUAAAA:8 a=uu6HZSQSBnFQn7oXV_IA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 a=cvBusfyB2V15izCimMoJ:22 a=AKGiAy9iJ-JzxKVHQNES:22 a=HywIFdX19-EX8Ph82vJO:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.680,FMLib:17.12.80.40 definitions=2025-04-23_07,2025-04-22_01,2025-02-21_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 lowpriorityscore=0 adultscore=0 spamscore=0 priorityscore=1501 mlxscore=0 mlxlogscore=628 malwarescore=0 impostorscore=0 clxscore=1015 suspectscore=0 phishscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2504070000 definitions=main-2504230084 On 4/22/25 11:31 PM, Danila Tikhonov wrote: > Add base dtsi for SM7150-AA/SM7150-AB/SM7150-AC SoCs > > Co-developed-by: David Wronek > Signed-off-by: David Wronek > Co-developed-by: Jens Reidel > Signed-off-by: Jens Reidel > Signed-off-by: Danila Tikhonov > --- [...] > + cpu0: cpu@0 { > + device_type = "cpu"; > + compatible = "qcom,kryo470"; Please split this into Kryo 470 silver and gold, with the former being based on CA55 and the latter on CA76 [...] > + pmu-a55 { > + compatible = "arm,cortex-a55-pmu"; > + interrupts = ; > + }; > + > + pmu-a76 { > + compatible = "arm,cortex-a78-pmu"; > + interrupts = ; > + }; Please update this, mimicking 2c06e0797c32 ("arm64: dts: qcom: sm8650: add PPI interrupt partitions for the ARM PMUs") > + > + psci { > + compatible = "arm,psci-1.0"; > + method = "smc"; > + > + cpu_pd0: power-domain-cpu0 { > + #power-domain-cells = <0>; > + power-domains = <&cluster_pd>; > + domain-idle-states = <&little_cpu_sleep_0 > + &little_cpu_sleep_1>; <&foo>, <&foo2>; because they are phandles to separate things - DTC treats them equally though.. [...] > + interconnects = <&aggre1_noc MASTER_QUP_0 QCOM_ICC_TAG_ALWAYS > + &config_noc SLAVE_QUP_0 QCOM_ICC_TAG_ALWAYS>, > + <&gem_noc MASTER_AMPSS_M0 QCOM_ICC_TAG_ALWAYS > + &config_noc SLAVE_QUP_0 QCOM_ICC_TAG_ALWAYS>, Paths involving AMPSS_M0 (the cpu endpoint) should be ACTIVE_ONLY, this applies to the entire file and all paths [...] > + remoteproc_adsp: remoteproc@62400000 { > + compatible = "qcom,sm7150-adsp-pas"; > + reg = <0x0 0x62400000 0x0 0x100>; This region is 0x10_000 long [...] > + adreno_smmu: iommu@5040000 { > + compatible = "qcom,sm7150-smmu-v2", > + "qcom,adreno-smmu", > + "qcom,smmu-v2"; > + reg = <0x0 0x05040000 0x0 0x10000>; > + > + interrupts = , > + , > + , > + , > + , > + , > + , > + , > + , > + ; > + > + clocks = <&gpucc GPU_CC_AHB_CLK>, > + <&gcc GCC_GPU_MEMNOC_GFX_CLK>, > + <&gcc GCC_GPU_SNOC_DVM_GFX_CLK>; > + clock-names = "ahb", > + "bus", > + "iface"; > + > + power-domains = <&gpucc CX_GDSC>; > + > + #iommu-cells = <1>; > + #global-interrupts = <2>; Add `dma-coherent` and check whether the GPU still works [...] > + }; > + > + gmu: gmu@506a000 { > + compatible = "qcom,adreno-gmu-618.0", > + "qcom,adreno-gmu"; > + reg = <0x0 0x0506a000 0x0 0x31000>, Make it 0x26_000 so that it doesn't leak into GPU_CC [...] > + tsens0: thermal-sensor@c263000 { > + compatible = "qcom,sm7150-tsens", > + "qcom,tsens-v2"; > + reg = <0x0 0x0c263000 0x0 0x1ff>, /* TM */ > + <0x0 0x0c222000 0x0 0x1ff>; /* SROT */ Please remove these comments [...] > + intc: interrupt-controller@17a00000 { > + compatible = "arm,gic-v3"; > + reg = <0x0 0x17a00000 0x0 0x10000>, /* GICD */ > + <0x0 0x17a60000 0x0 0x100000>; /* GICR * 8 */ And these ones too [...] > + thermal-zones { Please adjust this against https://lore.kernel.org/linux-arm-msm/20250219-x1e80100-thermal-fixes-v1-0-d110e44ac3f9@linaro.org/ (keep only critical trips with no sw cooling for the CPU, etc.) Konrad