From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adrian Hunter Subject: Re: [PATCH RFCv2 01/10] mmc: core: Add support to read command queue parameters Date: Tue, 22 Nov 2016 09:58:25 +0200 Message-ID: References: <1467033757-32498-1-git-send-email-riteshh@codeaurora.org> <1467033757-32498-2-git-send-email-riteshh@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: Received: from mga09.intel.com ([134.134.136.24]:2289 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752817AbcKVID3 (ORCPT ); Tue, 22 Nov 2016 03:03:29 -0500 In-Reply-To: Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Linus Walleij , Ritesh Harjani Cc: Ulf Hansson , "linux-mmc@vger.kernel.org" , "linux-arm-msm@vger.kernel.org" , Alex Lemberg , mateusz.nowak@intel.com, Yuliy.Izrailov@sandisk.com, Jaehoon Chung , Dong Aisheng , Asutosh Das , Zhangfei Gao , Sujit Reddy Thumma , kdorfman@codeaurora.org, David Griego , Sahitya Tummala , venkatg@codeaurora.org, Shawn Lin , Subhash Jadavani On 21/11/16 17:34, Linus Walleij wrote: > On Mon, Jun 27, 2016 at 3:22 PM, Ritesh Harjani wrote: > >> From: Asutosh Das >> >> eMMC cards with EXT_CSD version >= 8, optionally support command >> queuing feature as defined by JEDEC eMMC5.1. Add support for probing >> command queue feature for such type of cards. >> >> Signed-off-by: Sujit Reddy Thumma >> Signed-off-by: Asutosh Das >> Signed-off-by: Venkat Gopalakrishnan >> [subhashj@codeaurora.org: fixed trivial merge conflicts] >> Signed-off-by: Subhash Jadavani >> Signed-off-by: Ritesh Harjani > > Reviewed-by: Linus Walleij > > Even if we don't merge the specific mechanism provided by the > rest of the patches, this patch just make us know more about > the capabilities of the hardware we're running on, which is good. I think SW CMDQ is a better starting point: https://marc.info/?l=linux-mmc&m=147729857722285 It cleans up the queue thread a bit: https://marc.info/?l=linux-mmc&m=147729857222281&w=2 And introduces queue semantics: https://marc.info/?l=linux-mmc&m=147729863322314&w=2