From: <tomas.melin@vaisala.com>
To: chris@printf.net
Cc: linux-mmc@vger.kernel.org, tomas.melin@vaisala.com
Subject: [PATCH 3/3] mmc-utils: Fix return value check from set_partitioning_setting_completed()
Date: Mon, 29 Aug 2016 10:54:01 +0000 [thread overview]
Message-ID: <e324e967-ac52-e25c-618f-a89d2de22b39@vaisala.com> (raw)
Test was wrong way around. Function returns non-zero value on fail.
Signed-off-by: Tomas Melin <tomas.melin@vaisala.com>
---
mmc_cmds.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/mmc_cmds.c b/mmc_cmds.c
index 5f2b2b5..09be825 100644
--- a/mmc_cmds.c
+++ b/mmc_cmds.c
@@ -1071,7 +1071,7 @@ int do_create_gp_partition(int nargs, char **argv)
if (ret)
exit(1);
- if (!set_partitioning_setting_completed(dry_run, device, fd))
+ if (set_partitioning_setting_completed(dry_run, device, fd))
exit(1);
return 0;
@@ -1215,7 +1215,7 @@ int do_enh_area_set(int nargs, char **argv)
printf("Done setting ENH_USR area on %s\n", device);
- if (!set_partitioning_setting_completed(dry_run, device, fd))
+ if (set_partitioning_setting_completed(dry_run, device, fd))
exit(1);
return 0;
@@ -1279,8 +1279,8 @@ int do_write_reliability_set(int nargs, char **argv)
printf("Done setting EXT_CSD_WR_REL_SET to 0x%02x on %s\n",
value, device);
- if (!set_partitioning_setting_completed(dry_run, device, fd))
- exit(1);
+ if (set_partitioning_setting_completed(dry_run, device, fd))
+ exit(1);
return 0;
}
--
2.1.4
reply other threads:[~2016-08-29 10:54 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e324e967-ac52-e25c-618f-a89d2de22b39@vaisala.com \
--to=tomas.melin@vaisala.com \
--cc=chris@printf.net \
--cc=linux-mmc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).