From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 46B41262D0B for ; Thu, 19 Feb 2026 05:38:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771479495; cv=none; b=Z6aVNarRqtEzZep2jEmsGXptvfbIqhrxXNHMq5GJv7DeUUQIcveNDusRKqqD0ZFoxAGcsCTtfW5JP5I345cNsY/pXewmApp5oS42DrCq8g7MXWf97QeY+r170l3tBEEr85LSmWiBJmwFwAbjZZxuQ7PtzHCKzLnBFkhOQgruEfE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771479495; c=relaxed/simple; bh=JarSg4Iy2X5OeOrsbK3lxs8hqItkhx4v7l+xAx/pSn4=; h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=Evd1ChFrpFoO7sQOh2k4r47iQRrNZbBiVAB536m+P4Gv43eGwkEaL95CqcS9xsjyULWSFMuG6wIopgOckINSq4s4D3/N65szgKuqjQuXCi34EP1fQid9yMmfguj5v4Uz1xqMX2FRQqMBkDZ5iQfhBIiPvb3Gg90QkTPmYtVvDFU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=iUOTJcxI; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=RMr0o7Ja; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="iUOTJcxI"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="RMr0o7Ja" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61INpr4v2884192 for ; Thu, 19 Feb 2026 05:38:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= bx9vef0HkXb6vOZHSEYOmtJceWicO+PSjEh/i3J41t0=; b=iUOTJcxI5tVwiqCa /KjjOGai9QMxIxMzTxQo24CwE4R5X+J5euxtXcTyG5V54g+jlWpmuzcZWu7kGgnu QuS4JYOO0AM/aW7WFKgN6s26+YV1H5JDNOdyRN+nQ0wUAnFZGkooU9e3UD8AUTHT 40RDqL0Ysp0smn5otmWsm6KazMA6ipifrd21H70hoTslUA1u5Yy0I4ewLPy9H15+ SM3h/gWAc6kGTSdryVgNLsEks5slUqZfireVfW2A7GamY2Yd6C0a/k7k5w/hT3Zn rc+9MhPjBfQ1vT4WdK2RCUFA5+M6DI9F7CcyHvCC0pceXhjd71rVzM2o/1SDajE9 cq28/A== Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cdqfg8jnc-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 19 Feb 2026 05:38:11 +0000 (GMT) Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-82436a49592so273710b3a.2 for ; Wed, 18 Feb 2026 21:38:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1771479491; x=1772084291; darn=vger.kernel.org; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject:from:to:cc :subject:date:message-id:reply-to; bh=bx9vef0HkXb6vOZHSEYOmtJceWicO+PSjEh/i3J41t0=; b=RMr0o7Jaqfc2HTLMhvDZZdFTfs/0RnAg/JSAwp4JWkk88H3VW5M3xLi1Fmilamn1Vw 2RC9ID0+7HisfMNUq4mh7ZYhwMj2jPP5rS3G2GuaxuoL68I1rhEOEjf4ghZkWtp4W/QY 728NFMJhBCC6++Yrc2bgbbx253OuC8t6lpQ6QuWCx7f6uhASPlrabhOSSDvb/0FrAScu duou4v0gPf+YqHPzOIvsNB06DQ7lDcFAfTJdIaJ7SXwlMcYPj2kNSfTWzAkel8h4XjzN pY6qLJ4OXVSqmmqv5E+muqptkBt6e/hb3XiSPqI8+Lr8nHysn4SnOlLSHCIdf7GDsBwd ZmEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771479491; x=1772084291; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bx9vef0HkXb6vOZHSEYOmtJceWicO+PSjEh/i3J41t0=; b=A0UpEXvPuTAXhJcUOVBhDqPKvHlSrHw4bQSqdH9lBVKZGElp/9pSFPHIDciEneQa83 edQC6XNB8SiykDQG3v/ilERYRom86TbJWvdS5z4NiCiPz27KI6m3eE9oJ66mdF6TVfmx m5nDz0BmlR/6PuV8ln8ABIQ6+vs5ow2Yk5hC+CrAkIkFhHGJVTBTmJZ1GUymsIQ1MFR8 aSCcDeVCKRM6JI9Indvr7U4MAxGz7aUPLXaAGh+4OSXJC/PNlYKZtLA08LcbsrAVu5F6 hk/iYjnM877Q2D7o7YB+0rqaznu5k62gyb/eccXiGs5jPS1X3iC71lfnU+czCE2rhOOy cKTQ== X-Forwarded-Encrypted: i=1; AJvYcCWiY0Be9Z37sy6mYK5Hwx3n4u1nCm97wmxeINpYtj6gVb1tIohoWlNoCoan2UT19rszRepyxGDgP90=@vger.kernel.org X-Gm-Message-State: AOJu0YwSm2WPIrWo6t+lTPSV6IBcXgBLt3WereiVvEvWySQkKWO/J8hd 8y1XqSg1DkrzjrzZWXRkhmVq9pjqOQ64jkf5s/fpI+R06lfeo4CRgw22R3SVRi04KyYwbSnCldc HiX0BuOspBy1iRfeASyPgw+6Ou3ZkcUynH5f0z549SOJV2pParEAvkO+pX6nVzw4= X-Gm-Gg: AZuq6aKLuk62oJMYio9PJtDQzMYF2fthuqjCNYozol9rwI/i75gg4zajfXuPpCdwtDB GuvTNKpkvIStXYHEPKj+Esi9S3KTJfGito+JeQnfZGdv3NmzcL1lvZHMBUcDz26JhoIQI4hEsTk MvhlsUofr7DKJNOpux8bMzonWAlxSYvM+1KhriOXoBXpUk5MYSYENaIuESGA3fnUjvifDzWPG80 cuUff78Be3z/oSVcY5jlQ95/Nxv/3ekx6eE61NZr4zR4CDNJbKMmInFMdMFZXmUjzqEn9sYn5y5 Bm0azAanH1UlWXml7rS0gjY+2oGn0Bh/r/3jvZvCjn2aRsd+ubxFlBVzuifFNXyxY1ZqVsfebmp 1tek2QggEUXPfgx8i/YZ8KEFnUdU4c+cGsUJ+3oQIotimbvfdpQ== X-Received: by 2002:a05:6a00:7586:b0:821:70e7:74ca with SMTP id d2e1a72fcca58-824c965d569mr15419706b3a.70.1771479490933; Wed, 18 Feb 2026 21:38:10 -0800 (PST) X-Received: by 2002:a05:6a00:7586:b0:821:70e7:74ca with SMTP id d2e1a72fcca58-824c965d569mr15419671b3a.70.1771479490448; Wed, 18 Feb 2026 21:38:10 -0800 (PST) Received: from [10.217.222.63] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-824c6a409e6sm18351122b3a.18.2026.02.18.21.38.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Feb 2026 21:38:10 -0800 (PST) Subject: Re: [PATCH v4 1/3] dt-bindings: mmc: sdhci-msm: Add ICE phandle To: Krzysztof Kozlowski Cc: ulf.hansson@linaro.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, andersson@kernel.org, konradybcio@kernel.org, linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa , Abhinaba Rakshit References: <20260217052526.2335759-1-neeraj.soni@oss.qualcomm.com> <20260217052526.2335759-2-neeraj.soni@oss.qualcomm.com> <20260217-berserk-puma-of-focus-bcbe82@quoll> From: Neeraj Soni Message-ID: Date: Thu, 19 Feb 2026 11:08:05 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 Precedence: bulk X-Mailing-List: linux-mmc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: <20260217-berserk-puma-of-focus-bcbe82@quoll> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: kEjYyuPMt6SNWORLR64hXtJDnCGUABu_ X-Proofpoint-ORIG-GUID: kEjYyuPMt6SNWORLR64hXtJDnCGUABu_ X-Authority-Analysis: v=2.4 cv=A6hh/qWG c=1 sm=1 tr=0 ts=6996a1c3 cx=c_pps a=m5Vt/hrsBiPMCU0y4gIsQw==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=P-IC7800AAAA:8 a=VwQbUJbxAAAA:8 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=7CWuv0upaalPmBxTJ3QA:9 a=QEXdDO2ut3YA:10 a=IoOABgeZipijB_acs4fv:22 a=d3PnA9EDa4IxuAV0gXij:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjE5MDA0OCBTYWx0ZWRfX/sznoYia2eDa iUvn6tHf4uK/+TwtD3bVTIq5rwuzqnEaO80LUpWWwB0dDDgL2JufGuxPx610JPq0/ofzwIA71hN amre7dDSyLu56wSG+1kQuR0uaIHpowtaLAVy/IVgUCXc5WFRHcTY6xOTaU7qpPP+2H4jaKoDYrs lXG7SVsuiicjZXqlmH9XStsiICHUv3ojKJezOVDR8oVxJ30frAx3sflqAmrxutk+Weq5InV4hKi sVtdHYE63zz23/NlroswJOJ6WbAigOtlwEqmyRWF8ebcNSMvyoWhHutw+j2Jo4V37B+h7hdUv6j 24Zcr3+5MAtjSNGuuPBRwm6rpN6i9NFnUVfVUtNKFd8ig9cSlT1dTnbBzBiYzO/VnrBlj8AOYbe Q0yV3ShO3hJHJYWWcfKYB1GSBR7SgHvtE50CHOxkCgivrveg/XmC9wiAhQJV2CRYeexzvoOAqAc YLKcRle0QfE2UL1/5CA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-19_01,2026-02-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 priorityscore=1501 adultscore=0 impostorscore=0 suspectscore=0 spamscore=0 malwarescore=0 clxscore=1015 bulkscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602190048 On 2/18/2026 1:46 AM, Krzysztof Kozlowski wrote: > On Tue, Feb 17, 2026 at 10:55:24AM +0530, Neeraj Soni wrote: >> Starting with sc7280(kodiak), the ICE will have its own device-tree node. >> So add the qcom,ice property to reference it. >> >> To avoid double-modeling, when qcom,ice is present, disallow an embedded ICE > > Please wrap commit message according to Linux coding style / submission > process (neither too early nor over the limit): > https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597 > Ack. Will fix in next patch. >> register region in the SDHCI node. Older SoCs without ICE remain valid as >> no additional requirement is imposed. >> >> Co-developed-by: Abel Vesa >> Signed-off-by: Abel Vesa >> Co-developed-by: Abhinaba Rakshit >> Signed-off-by: Abhinaba Rakshit >> Signed-off-by: Neeraj Soni >> >> --- >> >> Some initial work is done by Abel here: >> https://lore.kernel.org/all/ba3da82d-999b-b040-5230-36e60293e0fd@linaro.org/ >> and by Abhinaba here: >> https://lore.kernel.org/all/20251009-add-separate-ice-ufs-and-emmc-device-nodes-for-qcs615-platform-v1-1-2a34d8d03c72@oss.qualcomm.com/ >> >> This patch adds the purpose and usage for phandle in the description and encodes >> it properly in the schema. >> --- >> .../devicetree/bindings/mmc/sdhci-msm.yaml | 15 +++++++++++++++ >> 1 file changed, 15 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml >> index 938be8228d66..9b902e0c8d09 100644 >> --- a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml >> +++ b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml >> @@ -140,6 +140,11 @@ properties: >> $ref: /schemas/types.yaml#/definitions/uint32 >> description: platform specific settings for DLL_CONFIG reg. >> >> + qcom,ice: >> + $ref: /schemas/types.yaml#/definitions/phandle >> + description: >> + phandle to the Inline Crypto Engine (ICE) hardware block for this controller. > > > Srsly, I asked once and not much improved. What is explicitly written in > coding style which I asked you twice to read? > I have attempted to modifiy it as per the comment you gave in v3 here: https://lore.kernel.org/all/b6e510da-b369-4c43-b9a1-455478af4948@kernel.org/ I will rephrase it to explain the usage better in next patch. > And how long is this line? Why such trivialities cannot be fixed and I > need to remind this every time? > It is 83 character long but i understand now you expect it to be wrapped at 75 as per kernel coding style. I missed it and stuck to the limit dt_binding_check tool allowed. Will fix in next patch. >> + >> iommus: >> minItems: 1 >> maxItems: 8 >> @@ -223,6 +228,16 @@ allOf: >> - const: cqhci >> - const: ice >> >> + - if: >> + required: >> + - qcom,ice >> + then: >> + properties: >> + reg-names: >> + not: >> + contains: >> + const: ice > > And reg is still 4? This is not correct syntax. You need to define > proper and final constraints per each device. I would write example, but > why... more things you could just ignore. > I had included changes for reg in v3: https://lore.kernel.org/all/20260206112053.3287756-2-neeraj.soni@oss.qualcomm.com/ but those were not reviewed so i assume them to be incorrect and dropped it. Will fix this in next patch and post. > Best regards, > Krzysztof > Regards, Neeraj