Re: [PATCH v4 0/9] Add SDUC Support

[Adrian Hunter <adrian.hunter@intel.com>]

On 27/08/24 13:58, Avri Altman wrote:
>>> On 27/08/24 10:45, Avri Altman wrote:
>>>>>> On 25/08/24 10:41, Avri Altman wrote:
>>>>>>> Ultra Capacity SD cards (SDUC) was already introduced in SD7.0.
>>>>>>> Those cards support capacity larger than 2TB and up to including 128TB.
>>>>>>> Thus, the address range of the card expands beyond the 32-bit
>>>>>>> command argument. To that end, a new command - CMD22 is defined,
>>>>>>> to carry the extra 6-bit upper part of the 38-bit block address
>>>>>>> that enable access to 128TB memory space.
>>>>>>>
>>>>>>> SDUC capacity is agnostic to the interface mode: UHS-I and UHS-II
>>>>>>> – Same as SDXC.
>>>>>>>
>>>>>>> The spec defines several extensions/modifications to the current
>>>>>>> SDXC cards, which we address in patches 1 - 10.  Otherwise
>>>>>>> requirements are out-of-scope of this change.  Specifically, CMDQ
>>>>>>> (CMD44+CMD45), and Extension for Video Speed Class (CMD20).
>>>>>>>
>>>>>>> First publication of SDUC was in [1].  This series was developed
>>>>>>> and tested separately from [1] and does not borrow from it.
>>>>>>>
>>>>>>> [1] https://lwn.net/Articles/982566/
>>>>>>
>>>>>> Perhaps add support for mmc_test
>>>> Actually, I am not sure what should be added to mmc_test as far as
>>>> SDUC
>>> indication:
>>>> from dmesg we have:
>>>> [ 4253.922220] mmc0: new ultra high speed SDR104 SDUC card at
>>>> address
>>>> d555 [ 4253.922409] mmcblk0: mmc0:d555 SR04T 3.72 TiB
>>>>
>>>> Additionally, we have the card size sysfs entry:
>>>> # cat /sys/block/mmcblk0/size
>>>> 7999258624
>>>>
>>>> As well as the csd which implies its capacity:
>>>> # cd /sys/class/mmc_host/mmc0/mmc0:* && cat csd
>>>> 800e0032db79007732bf7f800a404001
>>>>
>>>> What test did you had in mind?
>>>
>>> Doesn't all the I/O need CMD22 first?
> So I tried to add it, and it looks like I'll be needing 2 - 3 patches to enable mmc_test for sduc.
> How about disable it for now, planning to ameliorate it in the very near future?

Ok by me.