From mboxrd@z Thu Jan 1 00:00:00 1970 From: merez@codeaurora.org Subject: Re: [PATCH v4 2/2] mmc: core: Support packed command for eMMC4.5 device Date: Mon, 20 Feb 2012 13:22:37 -0800 (PST) Message-ID: References: <000b01ccdc0a$0336abc0$09a40340$%jun@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT Return-path: Received: from wolverine01.qualcomm.com ([199.106.114.254]:50916 "EHLO wolverine01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753944Ab2BTVWi (ORCPT ); Mon, 20 Feb 2012 16:22:38 -0500 In-Reply-To: <000b01ccdc0a$0336abc0$09a40340$%jun@samsung.com> Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Seungwon Jeon Cc: linux-mmc@vger.kernel.org, 'Chris Ball' , linux-kernel@vger.kernel.org > > @@ -1262,21 +1608,32 @@ static int mmc_blk_issue_rw_rq(struct mmc_queue > *mq, struct request *rqc) > int ret = 1, disable_multi = 0, retry = 0, type; > enum mmc_blk_status status; > struct mmc_queue_req *mq_rq; > - struct request *req; > + struct request *req, *prq; > struct mmc_async_req *areq; > + u8 reqs = 0; > > if (!rqc && !mq->mqrq_prev->req) > return 0; > > + if (rqc) > + reqs = mmc_blk_prep_packed_list(mq, rqc); > + > do { > if (rqc) { > - mmc_blk_rw_rq_prep(mq->mqrq_cur, card, 0, mq); > + if (reqs >= card->host->packed_min) In case host->packed_min will be set to a value bigger than 2 you will loose all the requests that were added to the packed list. If you want to support dynamic number of min packed requests you need to move the packed list preparation to queue.c where you can issue the fetched requests one after another, when (reqs < card->host->packed_min). > + mmc_blk_packed_hdr_wrq_prep(mq->mqrq_cur, card, mq, reqs); > + else > + mmc_blk_rw_rq_prep(mq->mqrq_cur, card, 0, mq); Thanks, Maya Erez Consultant for Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum