From: <Balamanikandan.Gunasundar@microchip.com>
To: <linus.walleij@linaro.org>
Cc: <dmitry.torokhov@gmail.com>, <ulf.hansson@linaro.org>,
<linux-kernel@vger.kernel.org>, <linux-mmc@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<Ludovic.Desroches@microchip.com>, <Nicolas.Ferre@microchip.com>,
<alexandre.belloni@bootlin.com>, <Hari.PrasathGE@microchip.com>,
<Balamanikandan.Gunasundar@microchip.com>
Subject: Re: [PATCH v5 3/3] mmc: atmel-mci: Move card detect gpio polarity quirk to gpiolib
Date: Thu, 24 Aug 2023 10:33:36 +0000 [thread overview]
Message-ID: <e6dc48bb-438e-42f1-a756-6995cff5516d@microchip.com> (raw)
In-Reply-To: <CACRpkdY83_nQx8tWRV9SJyD=-SvY+30FiSXkrb5vKkd+QfuPaA@mail.gmail.com>
On 24/08/23 2:03 pm, Linus Walleij wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> On Thu, Aug 24, 2023 at 8:39 AM <Balamanikandan.Gunasundar@microchip.com> wrote:
>
>>>> +#if IS_ENABLED(CONFIG_MMC_ATMELMCI)
>>>> + if (of_device_is_compatible(np->parent, "atmel,hsmci") &&
>>
>> The only difference above is "np->parent" while the existing code uses
>> "np". This is because the compatible string is defined in the parent
>> node here while the others have it in the same node.
>
> Aha. What about this right before the for-loop
> then:
>
> /* The Atmel MSMCI has the property in a child node of the device */
> if (IS_ENABLED(CONFIG_MMC_ATMELMCI) &&
> of_device_is_compatible(np->parent, "atmel,hsmci"))
> np = parent->np;
>
This looks good! I will send a v6.
Thanks,
Balamanikandan
> Yours,
> Linus Walleij
prev parent reply other threads:[~2023-08-24 10:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-23 10:40 [PATCH v5 0/3] mmc: atmel-mci: Convert to gpio descriptors Balamanikandan Gunasundar
2023-08-23 10:40 ` [PATCH v5 1/3] " Balamanikandan Gunasundar
2023-08-23 10:40 ` [PATCH v5 2/3] mmc: atmel-mci: move atmel MCI header file Balamanikandan Gunasundar
2023-08-23 10:40 ` [PATCH v5 3/3] mmc: atmel-mci: Move card detect gpio polarity quirk to gpiolib Balamanikandan Gunasundar
2023-08-23 12:41 ` Linus Walleij
2023-08-24 6:39 ` Balamanikandan.Gunasundar
2023-08-24 8:33 ` Linus Walleij
2023-08-24 10:33 ` Balamanikandan.Gunasundar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e6dc48bb-438e-42f1-a756-6995cff5516d@microchip.com \
--to=balamanikandan.gunasundar@microchip.com \
--cc=Hari.PrasathGE@microchip.com \
--cc=Ludovic.Desroches@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox