From: Bean Huo <beanhuo@iokpp.de>
To: Francesco Dolcini <francesco@dolcini.it>
Cc: ulf.hansson@linaro.org, adrian.hunter@intel.com,
beanhuo@micron.com, jakub.kwapisz@toradex.com,
rafael.beims@toradex.com, linux-mmc@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v3] mmc: Add quirk MMC_QUIRK_BROKEN_CACHE_FLUSH for Micron eMMC Q2J54A
Date: Wed, 27 Sep 2023 10:56:36 +0200 [thread overview]
Message-ID: <ef69122bc6aa64bd8df6c5a2d0ec6d82380d5560.camel@iokpp.de> (raw)
In-Reply-To: <ZQ3IWOpcSfjVqNYC@francesco-nb.int.toradex.com>
On Fri, 2023-09-22 at 19:01 +0200, Francesco Dolcini wrote:
> > +
> > + if (host->card->quirks &
> > MMC_QUIRK_BROKEN_CACHE_FLUSH &&
> > + !host->card->written_flag && !ret)
> > + host->card->written_flag = true;
>
> From what I can see this branch is followed for both REQ_OP_READ and
> REQ_OP_WRITE, and I would say we want to set this flag only for
> REQ_OP_WRITE.
>
> Am I wrong?
>
> Francesco
you are right, we only care about write, I will update it in the next
version, thanks for your review!
Kind regards,
Bean
next prev parent reply other threads:[~2023-09-27 8:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-21 20:34 [PATCH v3] mmc: Add quirk MMC_QUIRK_BROKEN_CACHE_FLUSH for Micron eMMC Q2J54A Bean Huo
2023-09-22 9:29 ` Greg KH
2023-09-23 10:50 ` Rafael Beims
2023-09-22 17:01 ` Francesco Dolcini
2023-09-27 8:56 ` Bean Huo [this message]
2023-09-25 14:06 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef69122bc6aa64bd8df6c5a2d0ec6d82380d5560.camel@iokpp.de \
--to=beanhuo@iokpp.de \
--cc=adrian.hunter@intel.com \
--cc=beanhuo@micron.com \
--cc=francesco@dolcini.it \
--cc=jakub.kwapisz@toradex.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=rafael.beims@toradex.com \
--cc=stable@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox