From: Krzysztof Kozlowski <krzk@kernel.org>
To: Charan Pedumuru <charan.pedumuru@gmail.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Tony Lindgren <tony@atomide.com>
Cc: linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] dt-bindings: mmc: ti-omap2420-mmc: convert text based binding to json schema
Date: Tue, 20 May 2025 16:09:21 +0200 [thread overview]
Message-ID: <f0ae042a-7c38-4e9d-9664-157afd861c3c@kernel.org> (raw)
In-Reply-To: <20250520-ti-omap-v3-1-aa845b301c4c@gmail.com>
On 20/05/2025 15:12, Charan Pedumuru wrote:
> Convert TI MMC host controller binding to YAML format.
> Changes during Conversion:
> - Add new properties 'dma', 'dma-names' under required.
Why?
> - Define two separate phandles for 'dmas' in the examples.
> - Include appropriate header file for interrupts and use
> it in the examples.
Examples are not the binding, so you can drop last two items.
>
> Signed-off-by: Charan Pedumuru <charan.pedumuru@gmail.com>
> ---
> Changes in v3:
...
> + dmas:
> + maxItems: 2
> +
> + dma-names:
> + items:
> + - const: tx
> + - const: rx
> +
> + ti,hwmods:
> + $ref: /schemas/types.yaml#/definitions/string
> + description:
> + List of hwmod names (ascii strings), that comes from the OMAP
> + HW documentation, attached to a device. Must contain at least
> + one hwmod.
Description does not match the property. It is not a list and where the
hwmod below:
> + pattern: "^msdi[0-9]+$"
I see msdi - is it something different?
There was no such description in original binding, so maybe you are
changing something but anyway it should be correct.
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - dmas
> + - dma-names
> + - ti,hwmods
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-05-20 14:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-20 13:12 [PATCH v3] dt-bindings: mmc: ti-omap2420-mmc: convert text based binding to json schema Charan Pedumuru
2025-05-20 14:09 ` Krzysztof Kozlowski [this message]
2025-05-21 5:59 ` Charan Pedumuru
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0ae042a-7c38-4e9d-9664-157afd861c3c@kernel.org \
--to=krzk@kernel.org \
--cc=charan.pedumuru@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=robh@kernel.org \
--cc=tony@atomide.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox