From: Shawn Lin <shawn.lin@rock-chips.com>
To: Evgeniy Didin <Evgeniy.Didin@synopsys.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
shawn.lin@rock-chips.com,
Alexey Brodkin <Alexey.Brodkin@synopsys.com>,
linux-mmc@vger.kernel.org,
Douglas Anderson <dianders@chromium.org>,
stable@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-snps-arc@lists.infradead.org,
Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>,
Vineet Gupta <Vineet.Gupta1@synopsys.com>
Subject: Re: [PATCH 1/2 v3] mmc: dw_mmc: Fix the DTO timeout overflow calculation for 32-bit systems
Date: Tue, 27 Feb 2018 09:46:39 +0800 [thread overview]
Message-ID: <f370f35e-64c4-eaff-e8db-92137fbb29f6@rock-chips.com> (raw)
In-Reply-To: <d955cc19-1398-3c05-4742-32664480d07d@rock-chips.com>
>
> #define DIV_ROUND_DOWN_ULL(ll, d) \
> ({ unsigned long long _tmp = (ll); do_div(_tmp, d); _tmp; })
>
> #define DIV_ROUND_UP_ULL(ll, d) DIV_ROUND_DOWN_ULL((ll) + (d) -
> 1, (d))
>
>
> It uses intermediate unsigned long long _tmp for your "multiply", namely
> MSEC_PER_SEC * drto_clks * drto_div, which could solves the problem.
> So I don't see why DIV_ROUND_UP_ULL can't work for you?
Take back. I misunderstood your "multiply", sorry.
>
>
>> /* add a bit spare time */
>>
>
>
>
_______________________________________________
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc
next prev parent reply other threads:[~2018-02-27 1:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-26 14:34 [PATCH 0/2 v3] mmc: dw_mmc: Fix DTO/STO timeout overflow calculation Evgeniy Didin
2018-02-26 14:34 ` [PATCH 1/2 v3] mmc: dw_mmc: Fix the DTO timeout overflow calculation for 32-bit systems Evgeniy Didin
2018-02-26 14:40 ` Andy Shevchenko
2018-02-27 1:14 ` Shawn Lin
2018-02-27 1:46 ` Shawn Lin [this message]
2018-03-01 1:22 ` kbuild test robot
2018-02-26 14:34 ` [PATCH 2/2 v3] mmc: dw_mmc: Fix the CTO " Evgeniy Didin
2018-02-26 14:39 ` Andy Shevchenko
2018-02-26 15:14 ` Evgeniy Didin
2018-02-26 16:53 ` Andy Shevchenko
2018-02-26 17:14 ` Evgeniy Didin
2018-02-26 18:30 ` Andy Shevchenko
2018-02-26 20:27 ` Alexey Brodkin
2018-02-27 3:52 ` Jisheng Zhang
2018-02-27 10:49 ` Andy Shevchenko
2018-02-27 3:02 ` [PATCH 0/2 v3] mmc: dw_mmc: Fix DTO/STO timeout overflow calculation Jisheng Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f370f35e-64c4-eaff-e8db-92137fbb29f6@rock-chips.com \
--to=shawn.lin@rock-chips.com \
--cc=Alexey.Brodkin@synopsys.com \
--cc=Eugeniy.Paltsev@synopsys.com \
--cc=Evgeniy.Didin@synopsys.com \
--cc=Vineet.Gupta1@synopsys.com \
--cc=dianders@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=stable@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox