From: Adrian Hunter <adrian.hunter@intel.com>
To: Linus Walleij <linus.walleij@linaro.org>,
Benjamin Beckmeyer <beckmeyer.b@rittal.de>
Cc: linux-mmc <linux-mmc@vger.kernel.org>,
"Ulf Hansson" <ulf.hansson@linaro.org>,
"Pierre Ossman" <pierre@ossman.eu>,
"Benoît Thébaudeau" <benoit@wsystem.com>,
"Fabio Estevam" <fabio.estevam@nxp.com>,
stable <stable@vger.kernel.org>
Subject: Re: [PATCH v5] RFT: mmc: sdhci: Implement an SDHCI-specific bounce buffer
Date: Mon, 15 Jan 2018 12:54:37 +0200 [thread overview]
Message-ID: <f4418b92-2c60-3208-4aa0-cae14d443b8b@intel.com> (raw)
In-Reply-To: <CACRpkdYN2TLfsiTxcJ-Vx0yAzQv4hQsrhOe0biofzXYhx5KRDw@mail.gmail.com>
On 15/01/18 11:53, Linus Walleij wrote:
> On Mon, Jan 15, 2018 at 7:07 AM, Benjamin Beckmeyer
> <beckmeyer.b@rittal.de> wrote:
>
>> Good morning,
>>
>>> - Requesting a test of this on i.MX. (Sorry Benjamin.)
>>
>> No worries. I did another test with your v5 patch, but it doesn't work.
>
> Wow that is weird.
>
> So v3 works.
>
> And it's not the code that bails out if we have nr_segs == 1
> because that code path is not taken.
>
> It is the 64K instead of 512K buffer that makes this happen,
> then.
That might be because you are not updating max_req_size.
> I guess I just respin v3 with the change that we fall back to
> 1 segment if we can's allocate coherent memory for the
> bounce buffer.
I would like to support pre_req() and post_req(). I have some code for that
if you are interested.
next prev parent reply other threads:[~2018-01-15 10:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-12 14:19 [PATCH v5] RFT: mmc: sdhci: Implement an SDHCI-specific bounce buffer Linus Walleij
2018-01-15 6:07 ` Benjamin Beckmeyer
2018-01-15 9:53 ` Linus Walleij
2018-01-15 10:54 ` Adrian Hunter [this message]
2018-01-15 11:58 ` Adrian Hunter
2018-01-15 12:22 ` Adrian Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4418b92-2c60-3208-4aa0-cae14d443b8b@intel.com \
--to=adrian.hunter@intel.com \
--cc=beckmeyer.b@rittal.de \
--cc=benoit@wsystem.com \
--cc=fabio.estevam@nxp.com \
--cc=linus.walleij@linaro.org \
--cc=linux-mmc@vger.kernel.org \
--cc=pierre@ossman.eu \
--cc=stable@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox