From: Adrian Hunter <adrian.hunter@intel.com>
To: Jaehoon Chung <jh80.chung@samsung.com>, linux-mmc@vger.kernel.org
Cc: ulf.hansson@linaro.org
Subject: Re: [PATCH] mmc: sdhci-s3c: add spin_unlock_irq() before calling clk_round_rate
Date: Thu, 1 Dec 2016 08:58:17 +0200 [thread overview]
Message-ID: <f702333c-70ea-714d-b5e8-23e53189ef68@intel.com> (raw)
In-Reply-To: <20161130060542.18225-1-jh80.chung@samsung.com>
On 30/11/16 08:05, Jaehoon Chung wrote:
> Before calling clk_round_rate(), put the spin_unlock_irq() in
> sdhci_s3c_consider_clock() function.
>
> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> drivers/mmc/host/sdhci-s3c.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c
> index 784c5a8..de219ca 100644
> --- a/drivers/mmc/host/sdhci-s3c.c
> +++ b/drivers/mmc/host/sdhci-s3c.c
> @@ -121,7 +121,9 @@ static unsigned int sdhci_s3c_consider_clock(struct sdhci_s3c *ourhost,
> * speed possible with selected clock source and skip the division.
> */
> if (ourhost->no_divider) {
> + spin_unlock_irq(&ourhost->host->lock);
> rate = clk_round_rate(clksrc, wanted);
> + spin_lock_irq(&ourhost->host->lock);
> return wanted - rate;
> }
>
>
next prev parent reply other threads:[~2016-12-01 7:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20161130060544epcas1p4e2cbb763842707125f98535dbb34fb28@epcas1p4.samsung.com>
2016-11-30 6:05 ` [PATCH] mmc: sdhci-s3c: add spin_unlock_irq() before calling clk_round_rate Jaehoon Chung
2016-12-01 4:31 ` Jaehoon Chung
2016-12-01 6:58 ` Adrian Hunter [this message]
2016-12-01 8:14 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f702333c-70ea-714d-b5e8-23e53189ef68@intel.com \
--to=adrian.hunter@intel.com \
--cc=jh80.chung@samsung.com \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox