public inbox for linux-mmc@vger.kernel.org
 help / color / mirror / Atom feed
From: Heiner Kallweit <hkallweit1@gmail.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Carlo Caione <carlo@caione.org>,
	Kevin Hilman <khilman@baylibre.com>,
	linux-mmc@vger.kernel.org
Subject: [PATCH 4/9] mmc: meson-gx: improve meson_mmc_irq_thread
Date: Tue, 31 Jan 2017 21:58:09 +0100	[thread overview]
Message-ID: <f7316bf1-1a3c-fe98-c676-442957acb09e@gmail.com> (raw)
In-Reply-To: <24e8bf35-50ce-270d-c0aa-12bb90d2e3d8@gmail.com>

Remove unneeded variable ret and simplify the if block.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
 drivers/mmc/host/meson-gx-mmc.c | 15 ++++++---------
 1 file changed, 6 insertions(+), 9 deletions(-)

diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
index 529a4f22..4ce4c640 100644
--- a/drivers/mmc/host/meson-gx-mmc.c
+++ b/drivers/mmc/host/meson-gx-mmc.c
@@ -670,7 +670,6 @@ static irqreturn_t meson_mmc_irq_thread(int irq, void *dev_id)
 	struct mmc_command *cmd = host->cmd;
 	struct mmc_data *data;
 	unsigned int xfer_bytes;
-	int ret = IRQ_HANDLED;
 
 	if (WARN_ON(!mrq))
 		return IRQ_NONE;
@@ -679,14 +678,12 @@ static irqreturn_t meson_mmc_irq_thread(int irq, void *dev_id)
 		return IRQ_NONE;
 
 	data = cmd->data;
-	if (data) {
+	if (data && data->flags & MMC_DATA_READ) {
 		xfer_bytes = data->blksz * data->blocks;
-		if (data->flags & MMC_DATA_READ) {
-			WARN_ON(xfer_bytes > host->bounce_buf_size);
-			sg_copy_from_buffer(data->sg, data->sg_len,
-					    host->bounce_buf, xfer_bytes);
-			data->bytes_xfered = xfer_bytes;
-		}
+		WARN_ON(xfer_bytes > host->bounce_buf_size);
+		sg_copy_from_buffer(data->sg, data->sg_len,
+				    host->bounce_buf, xfer_bytes);
+		data->bytes_xfered = xfer_bytes;
 	}
 
 	meson_mmc_read_resp(host->mmc, cmd);
@@ -695,7 +692,7 @@ static irqreturn_t meson_mmc_irq_thread(int irq, void *dev_id)
 	else
 		meson_mmc_start_cmd(host->mmc, data->stop);
 
-	return ret;
+	return IRQ_HANDLED;
 }
 
 /*
-- 
2.11.0



  parent reply	other threads:[~2017-01-31 21:07 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <24e8bf35-50ce-270d-c0aa-12bb90d2e3d8@gmail.com>
2017-01-31 20:57 ` [PATCH 2/9] mmc: meson-gx: minor improvements in meson_mmc_set_ios Heiner Kallweit
2017-02-01 11:55   ` Jaehoon Chung
2017-02-01 20:16     ` Heiner Kallweit
2017-02-03 13:52       ` Kevin Hilman
2017-01-31 20:58 ` [PATCH 3/9] mmc: meson-gx: improve meson_mmc_clk_set Heiner Kallweit
2017-02-01 12:24   ` Jaehoon Chung
2017-02-01 20:29     ` Heiner Kallweit
2017-02-02  9:09       ` Ulf Hansson
2017-01-31 20:58 ` Heiner Kallweit [this message]
2017-01-31 20:58 ` [PATCH 5/9] mmc: meson-gx: improve interrupt handling Heiner Kallweit
2017-01-31 20:58 ` [PATCH 6/9] mmc: meson-gx: set max block count and request size Heiner Kallweit
2017-01-31 20:58 ` [PATCH 7/9] mmc: meson-gx: reduce bounce buffer size Heiner Kallweit
2017-01-31 20:58 ` [PATCH 8/9] mmc: meson-gx: remove unneeded checks in remove Heiner Kallweit
2017-01-31 20:59 ` [PATCH 9/9] mmc: meson-gx: add support for HS400 mode Heiner Kallweit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f7316bf1-1a3c-fe98-c676-442957acb09e@gmail.com \
    --to=hkallweit1@gmail.com \
    --cc=carlo@caione.org \
    --cc=khilman@baylibre.com \
    --cc=linux-mmc@vger.kernel.org \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox