From: Adrian Hunter <adrian.hunter@intel.com>
To: Colin King <colin.king@canonical.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
linux-mmc@vger.kernel.org, Christoph Hellwig <hch@lst.de>
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][mmc-next] mmc: sdhci-pci: make guid intel_dsm_guid static
Date: Wed, 14 Jun 2017 09:08:03 +0300 [thread overview]
Message-ID: <f9b36c7a-1c69-d825-2bc2-ccb986ab2b22@intel.com> (raw)
In-Reply-To: <20170613131426.8132-1-colin.king@canonical.com>
On 13/06/17 16:14, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The guid intel_dsm_guid does not need to be in global scope, so make
> it static.
>
> Cleans up sparse warning:
> "symbol 'intel_dsm_guid' was not declared. Should it be static?"
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
But this patch is dependent on the guid changes which are not in the mmc
tree. It's in a tree of Christoph's I think.
> ---
> drivers/mmc/host/sdhci-pci-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-pci-core.c b/drivers/mmc/host/sdhci-pci-core.c
> index 3c02c5b394d6..f1d8385d91f0 100644
> --- a/drivers/mmc/host/sdhci-pci-core.c
> +++ b/drivers/mmc/host/sdhci-pci-core.c
> @@ -404,7 +404,7 @@ struct intel_host {
> bool d3_retune;
> };
>
> -const guid_t intel_dsm_guid =
> +static const guid_t intel_dsm_guid =
> GUID_INIT(0xF6C13EA5, 0x65CD, 0x461F,
> 0xAB, 0x7A, 0x29, 0xF7, 0xE8, 0xD5, 0xBD, 0x61);
>
>
next prev parent reply other threads:[~2017-06-14 6:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-13 13:14 [PATCH][mmc-next] mmc: sdhci-pci: make guid intel_dsm_guid static Colin King
2017-06-14 6:08 ` Adrian Hunter [this message]
2017-06-19 10:24 ` Ulf Hansson
2017-06-19 10:25 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f9b36c7a-1c69-d825-2bc2-ccb986ab2b22@intel.com \
--to=adrian.hunter@intel.com \
--cc=colin.king@canonical.com \
--cc=hch@lst.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox