Re: [PATCH v2 1/2] dt-bindings: mmc: mtk-sd: Document support for Airoha AN7581 SoC

[Krzysztof Kozlowski <krzk@kernel.org>]

On 28/10/2026 17:48, Christian Marangi wrote:
> On Wed, Oct 28, 2026 at 01:51:16PM +0100, Krzysztof Kozlowski wrote:
>> On Tue, Oct 27, 2026 at 03:40:00PM +0100, Christian Marangi wrote:
>>> Add dedicated compatible for Airoha AN7581 SoC integrated MMC controller.
>>> The MMC controller is based on the MT7988 with the difference that it does
>>> have a single clock controlling it.
>>>
>>> Add the dedicated compatible to describe the 2 register requirement and
>>> permit to define only 2 clock (the main one and a fixed clock for HS)
>>>
>>> Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
>>> ---
>>> Changes v2:
>>> - Also add compatible to restrict clock-names for source and hclk
>>>  Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 3 +++
>>>  1 file changed, 3 insertions(+)
>>>
>>
>> Your driver part suggests it's fully compatible with other variant. Why
>> not expressing it with fallback?
>>
> 
> You mean something like 
> 
>    compatible = "airoha,an7581-mmc", "mediatek,mt7988-mmc";
> 
> ? (my concern is if this would be problematic with the current if
> conditions in the schema)

I see, the first "if:then:" would be tricky to convert to "contains" for
the compatible, without bringing a few more conditional blocks. I guess
it's fine here.

Best regards,
Krzysztof