Re: [PATCH] mmc: mtk-sd: disable new_tx/rx and modify related settings for mt8189

["Cathy Xu (许华婷)" <ot_cathy.xu@mediatek.com>]

On Thu, 2026-02-05 at 12:47 +0100, AngeloGioacchino Del Regno wrote:
> Il 04/02/26 03:06, Cathy Xu ha scritto:
> > Disable new_tx/rx and modify related settings helps avoid data
> > transmission instability, and better compatibility for mt8189.
> > 
> > Signed-off-by: Cathy Xu <ot_cathy.xu@mediatek.com>
> 
> Needs a fixes tag. Please add the relevant one and resend.
> 
> Thanks,
> Angelo

  Thank you for your review, I will add it in next.

  Thanks,
  Cathy

> 
> > ---
> >   drivers/mmc/host/mtk-sd.c | 10 +++++-----
> >   1 file changed, 5 insertions(+), 5 deletions(-)
> > 
> > diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
> > index 302ac8529c4f..b2680cc054bd 100644
> > --- a/drivers/mmc/host/mtk-sd.c
> > +++ b/drivers/mmc/host/mtk-sd.c
> > @@ -682,15 +682,15 @@ static const struct mtk_mmc_compatible
> > mt8189_compat = {
> >   	.needs_top_base = true,
> >   	.pad_tune_reg = MSDC_PAD_TUNE0,
> >   	.async_fifo = true,
> > -	.data_tune = true,
> > +	.data_tune = false,
> >   	.busy_check = true,
> >   	.stop_clk_fix = true,
> > -	.stop_dly_sel = 1,
> > -	.pop_en_cnt = 2,
> > +	.stop_dly_sel = 3,
> > +	.pop_en_cnt = 8,
> >   	.enhance_rx = true,
> >   	.support_64g = true,
> > -	.support_new_tx = true,
> > -	.support_new_rx = true,
> > +	.support_new_tx = false,
> > +	.support_new_rx = false,
> >   	.support_spm_res_release = true,
> >   };
> >   
> 
>