From mboxrd@z Thu Jan 1 00:00:00 1970 From: merez@codeaurora.org Subject: Re: [PATCH v4 2/2] mmc: core: Support packed command for eMMC4.5 device Date: Wed, 15 Feb 2012 01:36:52 -0800 (PST) Message-ID: References: <000b01ccdc0a$0336abc0$09a40340$%jun@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT Return-path: Received: from wolverine01.qualcomm.com ([199.106.114.254]:31633 "EHLO wolverine01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755446Ab2BOJgw (ORCPT ); Wed, 15 Feb 2012 04:36:52 -0500 In-Reply-To: <000b01ccdc0a$0336abc0$09a40340$%jun@samsung.com> Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Seungwon Jeon Cc: linux-mmc@vger.kernel.org, 'Chris Ball' , linux-kernel@vger.kernel.org > @@ -1065,12 +1075,60 @@ static int mmc_blk_err_check(struct mmc_card > *card, > if (!brq->data.bytes_xfered) > return MMC_BLK_RETRY; > > + if (mq_mrq->packed_cmd != MMC_PACKED_NONE) { > + if (unlikely(brq->data.blocks << 9 != brq->data.bytes_xfered)) > + return MMC_BLK_PARTIAL; > + else > + return MMC_BLK_SUCCESS; > + } > + > if (blk_rq_bytes(req) != brq->data.bytes_xfered) > return MMC_BLK_PARTIAL; > > return MMC_BLK_SUCCESS; > } I think it would be best to keep the request length (brq->data.blocks << 9 or blk_rq_bytes(req)) in a variable and use it in the original if above. This way you can avoid doubling the exit points from the function. Thanks, Maya Erez Consultant for Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum