From: Adrian Hunter <adrian.hunter@intel.com>
To: Jisheng Zhang <jszhang@kernel.org>, Ulf Hansson <ulf.hansson@linaro.org>
Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mmc: sdhci-of-dwcmshc: Remove useless "&" of th1520_execute_tuning
Date: Mon, 15 Apr 2024 09:14:40 +0300 [thread overview]
Message-ID: <fda632a1-e0b1-4b88-82a6-03f476c73ac9@intel.com> (raw)
In-Reply-To: <20240414164357.2841-1-jszhang@kernel.org>
On 14/04/24 19:43, Jisheng Zhang wrote:
> The preceding "&" before th1520_execute_tuning is useless, remove it.
>
> Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> drivers/mmc/host/sdhci-of-dwcmshc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-of-dwcmshc.c b/drivers/mmc/host/sdhci-of-dwcmshc.c
> index 7b55acd9830c..6206ff7615e8 100644
> --- a/drivers/mmc/host/sdhci-of-dwcmshc.c
> +++ b/drivers/mmc/host/sdhci-of-dwcmshc.c
> @@ -822,7 +822,7 @@ static const struct sdhci_ops sdhci_dwcmshc_th1520_ops = {
> .reset = th1520_sdhci_reset,
> .adma_write_desc = dwcmshc_adma_write_desc,
> .voltage_switch = dwcmshc_phy_1_8v_init,
> - .platform_execute_tuning = &th1520_execute_tuning,
> + .platform_execute_tuning = th1520_execute_tuning,
> };
>
> static const struct sdhci_ops sdhci_dwcmshc_cv18xx_ops = {
next prev parent reply other threads:[~2024-04-15 6:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-14 16:43 [PATCH] mmc: sdhci-of-dwcmshc: Remove useless "&" of th1520_execute_tuning Jisheng Zhang
2024-04-15 6:14 ` Adrian Hunter [this message]
2024-04-25 16:21 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fda632a1-e0b1-4b88-82a6-03f476c73ac9@intel.com \
--to=adrian.hunter@intel.com \
--cc=jszhang@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox