public inbox for linux-mmc@vger.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Shmidt <dimitrysh@android.com>
To: linux-mmc@vger.kernel.org
Subject: mmc_rescan failure in case of CONFIG_MMC_UNSAFE_RESUME
Date: Sat, 12 Feb 2011 00:33:33 +0000 (UTC)	[thread overview]
Message-ID: <loom.20110212T012758-658@post.gmane.org> (raw)

Hello,

Recently new check was added to core.c function mmc_rescan():
    if (host->bus_ops && host->bus_ops->detect && !host->bus_dead
        && mmc_card_is_removable(host)) <<<< This one
        host->bus_ops->detect(host);
mmc_card_is_removable() is checking
 !(host->caps & MMC_CAP_NONREMOVABLE) && mmc_assume_removable;

If we use CONFIG_MMC_UNSAFE_RESUME then
  mmc_assume_removable will be 0 and any card will be always considered
as non-removable. And host->bus_ops->detect() will not be called on card
removal.

Am I missing something?
Thanks,

Dmitry


             reply	other threads:[~2011-02-12  0:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-12  0:33 Dmitry Shmidt [this message]
2011-02-12 17:22 ` mmc_rescan failure in case of CONFIG_MMC_UNSAFE_RESUME Chris Ball
2011-02-14 19:04   ` Dmitry Shmidt
2011-02-14 19:40     ` Chris Ball
2011-02-14 21:54       ` Dmitry Shmidt
2011-02-15 18:06         ` Dmitry Shmidt
2011-02-16 17:37           ` Dmitry Shmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=loom.20110212T012758-658@post.gmane.org \
    --to=dimitrysh@android.com \
    --cc=linux-mmc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox