public inbox for linux-mmc@vger.kernel.org
 help / color / mirror / Atom feed
From: David Taylor <dmtaylor@skytex.net>
To: linux-mmc@vger.kernel.org
Subject: Re: [PATCH] mmc: core: Kill block requests if card is removed
Date: Tue, 22 Nov 2011 20:18:31 +0000 (UTC)	[thread overview]
Message-ID: <loom.20111122T210615-276@post.gmane.org> (raw)
In-Reply-To: 1320813119-24383-1-git-send-email-sthumma@codeaurora.org

Sujit Reddy Thumma <sthumma <at> codeaurora.org> writes:

> 
> Kill block requests when the host knows that the card is
> removed from the slot and is sure that subsequent requests
> are bound to fail. Do this silently so that the block
> layer doesn't output unnecessary error messages.
> 
> This patch implements suggestion from Adrian Hunter,
> http://thread.gmane.org/gmane.linux.kernel.mmc/2714/focus=3474
> 
> Signed-off-by: Sujit Reddy Thumma <sthumma <at> codeaurora.org>
> ---
>  drivers/mmc/card/queue.c |    5 +++++
>  drivers/mmc/core/bus.c   |    2 ++
>  include/linux/mmc/card.h |    3 +++
>  3 files changed, 10 insertions(+), 0 deletions(-)
> 

Thanks, this patch worked nicely to control a seemingly endless series of 
driver complaints when the SD card was removed during a transfer.

The OMAP4 I'm working on has hardware assisted detection of card removal, and 
this patch looks like it will be sufficient.


  parent reply	other threads:[~2011-11-22 21:40 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-09  4:31 [PATCH] mmc: core: Kill block requests if card is removed Sujit Reddy Thumma
2011-11-09  9:34 ` Adrian Hunter
2011-11-09 20:53   ` Per Forlin
2011-11-09 22:05     ` Per Forlin
2011-11-10  4:13       ` Sujit Reddy Thumma
2011-11-10  4:02     ` Sujit Reddy Thumma
2011-11-10  9:35       ` Adrian Hunter
2011-11-10 14:20         ` Per Forlin
2011-11-14  4:19           ` Sujit Reddy Thumma
2011-11-14  7:52             ` Per Forlin
2011-11-14  8:24               ` Per Forlin
2011-11-14  8:46                 ` Sujit Reddy Thumma
2011-11-09 21:47 ` Per Forlin
2011-11-10  5:31   ` Sujit Reddy Thumma
2011-11-22 20:18 ` David Taylor [this message]
2011-11-24  9:30   ` Per Forlin
2011-11-24 11:31     ` Sujit Reddy Thumma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=loom.20111122T210615-276@post.gmane.org \
    --to=dmtaylor@skytex.net \
    --cc=linux-mmc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox