From mboxrd@z Thu Jan 1 00:00:00 1970 From: Prasanna NAVARATNA Subject: Re: [PATCH] mmc: core: restore ocr and operation voltage in resume Date: Thu, 4 Apr 2013 12:26:01 +0000 (UTC) Message-ID: References: <1361352662-12263-1-git-send-email-kliu5@marvell.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Return-path: Received: from plane.gmane.org ([80.91.229.3]:54221 "EHLO plane.gmane.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759726Ab3DDM0Y (ORCPT ); Thu, 4 Apr 2013 08:26:24 -0400 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1UNjFY-0003l0-VC for linux-mmc@vger.kernel.org; Thu, 04 Apr 2013 14:26:40 +0200 Received: from 202.122.18.226 ([202.122.18.226]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 04 Apr 2013 14:26:40 +0200 Received: from prasanna.navaratna by 202.122.18.226 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 04 Apr 2013 14:26:40 +0200 Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: linux-mmc@vger.kernel.org So you agree the ocr mask must not be reset during suspend. The patch over here exactly addresses the problem which you stated :- "mmc core should tell the host driver to use the properly negotiated ocr mask to set the voltage level, both at initialization and at resume" The patch saves the ocr which is properly negotiated during initialization time and then restores it back during resume. Will you please elaborate, what is wrong with this patch? Or are you trying to tell, this is not the proper way to do the same? Thanks & Regards, Prasanna NAVARATNA