From: Prasanna NAVARATNA <prasanna.navaratna@gmail.com>
To: linux-mmc@vger.kernel.org
Subject: Re: [PATCH] mmc: core: restore ocr and operation voltage in resume
Date: Fri, 5 Apr 2013 06:07:11 +0000 (UTC) [thread overview]
Message-ID: <loom.20130405T080017-884@post.gmane.org> (raw)
In-Reply-To: CAPDyKFp8LEd7qb+afJbvUZFSNuDVL3SXshnEH5cuhSgH8L+drA@mail.gmail.com
Ulf Hansson <ulf.hansson <at> linaro.org> writes:
> "host->ocr" is intended for keeping the negotiated ocr mask. Another
> variable is not needed.
>
> A proper patch would in principle remove the workaround, which means
> the reset of the "host->ocr" in mmc_power_off is not done any more.
>
> Exactly what you need to make this work, is as stated before a bit
> more complicated.
Hello Ulf,
The work around is introduced by yourself :-
"At power off, reset OCR mask to be the highest possible voltage
supported for the current mmc host.
This solves the re-initialization during the power up sequence.
The voltage may have been decreased due to the card accepts a lower
voltage than the voltage used during the initialization sequence.
We need to reset the voltage to by the host highest possible value
since according to _specification_ the initialization must always be
done at high voltage"
So do you think, solution to current issue is to revert this patch? This
will not violate the spec as you are mentioning above?
If you agree, i'll push a new patch by reverting this. Else consider another
way in my new post "mmc: core: negotiate ocr during resume"
This patch will follow the spec and will also negotiate ocr during
mmc_resume_host.
Thanks,
Prasanna NAVARATNA
next prev parent reply other threads:[~2013-04-05 6:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-20 9:31 [PATCH] mmc: core: restore ocr and operation voltage in resume Kevin Liu
2013-04-04 9:44 ` Prasanna NAVARATNA
2013-04-04 10:06 ` Ulf Hansson
2013-04-04 10:43 ` Prasanna NAVARATNA
2013-04-04 11:47 ` Ulf Hansson
2013-04-04 12:26 ` Prasanna NAVARATNA
2013-04-04 14:43 ` Prasanna NAVARATNA
2013-04-04 15:37 ` Ulf Hansson
2013-04-05 6:07 ` Prasanna NAVARATNA [this message]
2013-04-05 9:39 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=loom.20130405T080017-884@post.gmane.org \
--to=prasanna.navaratna@gmail.com \
--cc=linux-mmc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox