* [PATCH] mmc: dw_mmc: Clear the DDR mode for non-DDR
@ 2012-01-02 7:00 Seungwon Jeon
2012-01-03 10:29 ` Will Newton
0 siblings, 1 reply; 3+ messages in thread
From: Seungwon Jeon @ 2012-01-02 7:00 UTC (permalink / raw)
To: linux-mmc; +Cc: 'Chris Ball', linux-samsung-soc
UHS_REG should be cleared for non-DDR mode. But currently there is
no way to clear DDR mode, if it is already set once. This patch adds
clearing DDR mode for non-DDD mode.
Signed-off-by: Seungwon Jeon <tgih.jun@samsung.com>
---
drivers/mmc/host/dw_mmc.c | 11 +++++++----
1 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
index c583b94..94e2238 100644
--- a/drivers/mmc/host/dw_mmc.c
+++ b/drivers/mmc/host/dw_mmc.c
@@ -707,12 +707,15 @@ static void dw_mci_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
break;
}
+ regs = mci_readl(slot->host, UHS_REG);
+
/* DDR mode set */
- if (ios->timing == MMC_TIMING_UHS_DDR50) {
- regs = mci_readl(slot->host, UHS_REG);
+ if (ios->timing == MMC_TIMING_UHS_DDR50)
regs |= (0x1 << slot->id) << 16;
- mci_writel(slot->host, UHS_REG, regs);
- }
+ else
+ regs &= ~(0x1 << slot->id) << 16;
+
+ mci_writel(slot->host, UHS_REG, regs);
if (ios->clock) {
/*
--
1.7.0.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] mmc: dw_mmc: Clear the DDR mode for non-DDR
2012-01-02 7:00 [PATCH] mmc: dw_mmc: Clear the DDR mode for non-DDR Seungwon Jeon
@ 2012-01-03 10:29 ` Will Newton
2012-01-05 3:32 ` Chris Ball
0 siblings, 1 reply; 3+ messages in thread
From: Will Newton @ 2012-01-03 10:29 UTC (permalink / raw)
To: Seungwon Jeon; +Cc: linux-mmc, Chris Ball, linux-samsung-soc
On Mon, Jan 2, 2012 at 7:00 AM, Seungwon Jeon <tgih.jun@samsung.com> wrote:
> UHS_REG should be cleared for non-DDR mode. But currently there is
> no way to clear DDR mode, if it is already set once. This patch adds
> clearing DDR mode for non-DDD mode.
>
> Signed-off-by: Seungwon Jeon <tgih.jun@samsung.com>
> ---
> drivers/mmc/host/dw_mmc.c | 11 +++++++----
> 1 files changed, 7 insertions(+), 4 deletions(-)
Looks ok to me, although I don't have any DDR capable hardware to test.
Acked-by: Will Newton <will.newton@imgtec.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mmc: dw_mmc: Clear the DDR mode for non-DDR
2012-01-03 10:29 ` Will Newton
@ 2012-01-05 3:32 ` Chris Ball
0 siblings, 0 replies; 3+ messages in thread
From: Chris Ball @ 2012-01-05 3:32 UTC (permalink / raw)
To: Will Newton; +Cc: Seungwon Jeon, linux-mmc, linux-samsung-soc
Hi,
On Tue, Jan 03 2012, Will Newton wrote:
> On Mon, Jan 2, 2012 at 7:00 AM, Seungwon Jeon <tgih.jun@samsung.com> wrote:
>> UHS_REG should be cleared for non-DDR mode. But currently there is
>> no way to clear DDR mode, if it is already set once. This patch adds
>> clearing DDR mode for non-DDD mode.
>>
>> Signed-off-by: Seungwon Jeon <tgih.jun@samsung.com>
>> ---
>> drivers/mmc/host/dw_mmc.c | 11 +++++++----
>> 1 files changed, 7 insertions(+), 4 deletions(-)
>
> Looks ok to me, although I don't have any DDR capable hardware to test.
>
> Acked-by: Will Newton <will.newton@imgtec.com>
Thanks, pushed to mmc-next for 3.3.
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-01-05 3:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-02 7:00 [PATCH] mmc: dw_mmc: Clear the DDR mode for non-DDR Seungwon Jeon
2012-01-03 10:29 ` Will Newton
2012-01-05 3:32 ` Chris Ball
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox