From: Chris Ball <cjb@laptop.org>
To: Jaehoon Chung <jh80.chung@samsung.com>
Cc: linux-mmc <linux-mmc@vger.kernel.org>,
Kyungmin Park <kyungmin.park@samsung.com>
Subject: Re: [PATCH] mmc: sdhci-s3c: fix wrong error-control
Date: Tue, 11 Oct 2011 10:03:39 -0400 [thread overview]
Message-ID: <m239ezlj5w.fsf@bob.laptop.org> (raw)
In-Reply-To: <4E93D107.200@samsung.com> (Jaehoon Chung's message of "Tue, 11 Oct 2011 14:15:51 +0900")
Hi,
On Tue, Oct 11 2011, Jaehoon Chung wrote:
> If sc->clk_bus[ptr] is NULL, happen NULL pointer error.
>
> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> drivers/mmc/host/sdhci-s3c.c | 6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c
> index 82709b6..3d00e72 100644
> --- a/drivers/mmc/host/sdhci-s3c.c
> +++ b/drivers/mmc/host/sdhci-s3c.c
> @@ -567,8 +567,10 @@ static int __devinit sdhci_s3c_probe(struct
> platform_device *pdev)
>
> err_req_regs:
> for (ptr = 0; ptr < MAX_BUS_CLK; ptr++) {
> - clk_disable(sc->clk_bus[ptr]);
> - clk_put(sc->clk_bus[ptr]);
> + if (sc->clk_bus[ptr]) {
> + clk_disable(sc->clk_bus[ptr]);
> + clk_put(sc->clk_bus[ptr]);
> + }
> }
>
> err_no_busclks:
Patch is corrupt due to line-wrapping.
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
prev parent reply other threads:[~2011-10-11 14:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-11 5:15 [PATCH] mmc: sdhci-s3c: fix wrong error-control Jaehoon Chung
2011-10-11 14:03 ` Chris Ball [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m239ezlj5w.fsf@bob.laptop.org \
--to=cjb@laptop.org \
--cc=jh80.chung@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-mmc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox