From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Ball Subject: Re: [PATCH] mmc: core: Fix voltage select in DDR mode Date: Sat, 24 Dec 2011 21:24:11 -0500 Message-ID: References: <1323950262-2160-1-git-send-email-girish.shivananjappa@linaro.org> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from void.printf.net ([89.145.121.20]:39342 "EHLO void.printf.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754186Ab1LYCYX (ORCPT ); Sat, 24 Dec 2011 21:24:23 -0500 In-Reply-To: <1323950262-2160-1-git-send-email-girish.shivananjappa@linaro.org> (Girish K. S.'s message of "Thu, 15 Dec 2011 17:27:42 +0530") Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Girish K S Cc: linux-mmc@vger.kernel.org, patches@linaro.org, linux-samsung-soc@vger.kernel.org, Philip Rakity , Arindam Nath Hi Girish, On Thu, Dec 15 2011, Girish K S wrote: > This patch fixes the wrong comparison before setting the interface > voltage in DDR mode. > > The assignment to the variable ddr before comaprison is either > ddr = MMC_1_2V_DDR_MODE; or ddr == MMC_1_8V_DDR_MODE. But the comparison > is done wth the extended csd value if (ddr == EXT_CSD_CARD_TYPE_DDR_1_2V) > > cc: Philip Rakity > cc: Arindam Nath > cc: Chris Ball > Signed-off-by: Girish K S Pushed to mmc-next for 3.3 with ACKs from Philip and Subhash and a stable@ tag, thanks. (It's too late for 3.2.) - Chris. -- Chris Ball One Laptop Per Child