From: Chris Ball <cjb@laptop.org>
To: Jaehoon Chung <jh80.chung@samsung.com>
Cc: "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
Kyungmin Park <kyungmin.park@samsung.com>
Subject: Re: [PATCH] mmc: use defined macro for card status
Date: Thu, 11 Aug 2011 17:42:43 -0400 [thread overview]
Message-ID: <m27h6jpquk.fsf@bob.laptop.org> (raw)
In-Reply-To: <4E425374.7060706@samsung.com> (Jaehoon Chung's message of "Wed, 10 Aug 2011 18:46:28 +0900")
Hi Jaehoon,
On Wed, Aug 10 2011, Jaehoon Chung wrote:
> Sometime we need to check the card status.
> So using R1_CURRENT_STATE(status)..and compare with R1_STATE_xxx.
> But some code didn't use R1_STATE_xxx.
>
> I think good that use defined macro for checking card status.
>
> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> drivers/mmc/card/mmc_test.c | 2 +-
> drivers/mmc/core/core.c | 2 +-
> drivers/mmc/core/mmc_ops.c | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mmc/card/mmc_test.c b/drivers/mmc/card/mmc_test.c
> index 742dc98..2bf229a 100644
> --- a/drivers/mmc/card/mmc_test.c
> +++ b/drivers/mmc/card/mmc_test.c
> @@ -224,7 +224,7 @@ static void mmc_test_prepare_mrq(struct mmc_test_card *test,
> static int mmc_test_busy(struct mmc_command *cmd)
> {
> return !(cmd->resp[0] & R1_READY_FOR_DATA) ||
> - (R1_CURRENT_STATE(cmd->resp[0]) == 7);
> + (R1_CURRENT_STATE(cmd->resp[0]) == R1_STATE_PRG);
> }
>
> /*
> diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c
> index f091b43..bfb86a6 100644
> --- a/drivers/mmc/core/core.c
> +++ b/drivers/mmc/core/core.c
> @@ -1501,7 +1501,7 @@ static int mmc_do_erase(struct mmc_card *card, unsigned int from,
> goto out;
> }
> } while (!(cmd.resp[0] & R1_READY_FOR_DATA) ||
> - R1_CURRENT_STATE(cmd.resp[0]) == 7);
> + R1_CURRENT_STATE(cmd.resp[0]) == R1_STATE_PRG);
> out:
> return err;
> }
> diff --git a/drivers/mmc/core/mmc_ops.c b/drivers/mmc/core/mmc_ops.c
> index 845ce7c..770c3d0 100644
> --- a/drivers/mmc/core/mmc_ops.c
> +++ b/drivers/mmc/core/mmc_ops.c
> @@ -407,7 +407,7 @@ int mmc_switch(struct mmc_card *card, u8 set, u8 index, u8 value,
> break;
> if (mmc_host_is_spi(card->host))
> break;
> - } while (R1_CURRENT_STATE(status) == 7);
> + } while (R1_CURRENT_STATE(status) == R1_STATE_PRG);
>
> if (mmc_host_is_spi(card->host)) {
> if (status & R1_SPI_ILLEGAL_COMMAND)
Thanks, pushed to mmc-next for 3.1.
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
prev parent reply other threads:[~2011-08-11 21:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-10 9:46 [PATCH] mmc: use defined macro for card status Jaehoon Chung
2011-08-11 21:42 ` Chris Ball [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m27h6jpquk.fsf@bob.laptop.org \
--to=cjb@laptop.org \
--cc=jh80.chung@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-mmc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox