From: Chris Ball <cjb@laptop.org>
To: Will Newton <will.newton@gmail.com>
Cc: Seungwon Jeon <tgih.jun@samsung.com>,
linux-samsung-soc@vger.kernel.org, linux-mmc@vger.kernel.org,
akpm@linux-foundation.org, kgene.kim@samsung.com
Subject: Re: [PATCH] mmc: dw_mmc: protect a sequence of request and request-done.
Date: Mon, 20 Jun 2011 14:58:23 -0400 [thread overview]
Message-ID: <m27h8gz5ww.fsf@bob.laptop.org> (raw)
In-Reply-To: <BANLkTin1p20oOAft+cfKYcxUVE6Fh065UA@mail.gmail.com> (Will Newton's message of "Mon, 20 Jun 2011 10:15:03 +0100")
Hi,
On Mon, Jun 20 2011, Will Newton wrote:
> On Mon, Jun 20, 2011 at 9:24 AM, Seungwon Jeon <tgih.jun@samsung.com> wrote:
>> Response timeout(RTO), Response crc error(RCRC) and Response error(RE)
>> signals come with command done(CD) and can be raised preceding command
>> done(CD). That is these error interrupts and CD can be handled in
>> separate dw_mci_interrupt(). If mmc_request_done() is called because of
>> response timeout before command done is occured, next request can be
>> sent, but CD of current request is not finished. This can bring about
>> a broken sequence of request and request-done.
>>
>> And Data error interrupt(DRTO, DCRC, SBE, EBE) and data transfer
>> over(DTO) are same reanson.
>>
>> Signed-off-by: Seungwon Jeon <tgih.jun@samsung.com>
>
> Acked-by: Will Newton <will.newton@imgtec.com>
Pushed to mmc-next for 3.1, thanks.
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
prev parent reply other threads:[~2011-06-20 18:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-20 8:24 [PATCH] mmc: dw_mmc: protect a sequence of request and request-done Seungwon Jeon
2011-06-20 9:15 ` Will Newton
2011-06-20 18:58 ` Chris Ball [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m27h8gz5ww.fsf@bob.laptop.org \
--to=cjb@laptop.org \
--cc=akpm@linux-foundation.org \
--cc=kgene.kim@samsung.com \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=tgih.jun@samsung.com \
--cc=will.newton@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox