From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Ball Subject: Re: [PATCH] mmc: dw_mmc: protect a sequence of request and request-done. Date: Mon, 20 Jun 2011 14:58:23 -0400 Message-ID: References: <1308558256-20824-1-git-send-email-tgih.jun@samsung.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: (Will Newton's message of "Mon, 20 Jun 2011 10:15:03 +0100") Sender: linux-samsung-soc-owner@vger.kernel.org To: Will Newton Cc: Seungwon Jeon , linux-samsung-soc@vger.kernel.org, linux-mmc@vger.kernel.org, akpm@linux-foundation.org, kgene.kim@samsung.com List-Id: linux-mmc@vger.kernel.org Hi, On Mon, Jun 20 2011, Will Newton wrote: > On Mon, Jun 20, 2011 at 9:24 AM, Seungwon Jeon wrote: >> Response timeout(RTO), Response crc error(RCRC) and Response error(RE) >> signals come with command done(CD) and can be raised preceding command >> done(CD). That is these error interrupts and CD can be handled in >> separate dw_mci_interrupt(). If mmc_request_done() is called because of >> response timeout before command done is occured, next request can be >> sent, but CD of current request is not finished. This can bring about >> a broken sequence of request and request-done. >> >> And Data error interrupt(DRTO, DCRC, SBE, EBE) and data transfer >> over(DTO) are same reanson. >> >> Signed-off-by: Seungwon Jeon > > Acked-by: Will Newton Pushed to mmc-next for 3.1, thanks. - Chris. -- Chris Ball One Laptop Per Child