public inbox for linux-mmc@vger.kernel.org
 help / color / mirror / Atom feed
From: Chris Ball <cjb@laptop.org>
To: Koen Beel <koen.beel.barco@gmail.com>
Cc: linux-mmc@vger.kernel.org, shawn.guo@freescale.com,
	w.sang@pengutronix.de
Subject: Re: [PATCH] mxs-mmc: fix clock rate setting
Date: Sat, 09 Jul 2011 17:04:39 -0400	[thread overview]
Message-ID: <m2ei1zkvx4.fsf@bob.laptop.org> (raw)
In-Reply-To: <BANLkTinKcb-=m3sURawdEjR=vTt=ApBKaQ@mail.gmail.com> (Koen Beel's message of "Thu, 30 Jun 2011 12:13:34 +0200")

Hi Koen,

On Thu, Jun 30 2011, Koen Beel wrote:
> Fix clock rate setting on mxs-mmc driver.
> Previously, if div2 was zero the value for TIMING_CLOCK_RATE would
> have been 255 instead of 0.
> Also the limits for div1 (TIMING_CLOCK_DIVIDE) and div2
> (TIMING_CLOCK_RATE + 1) where not correctly defined.
>
> Can easily be reproduced on mx23evk: default clock for high speed sdio
> cards is 50 MHz. With a SSP_CLK of 28.8 MHz (default), this resulted in
> an actual clock rate of about 56 kHz.

(I'm waiting for a v2 patch of this patch incorporating Wolfram's
requested changes before merging it.)

Thanks,

- Chris.
-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child

      parent reply	other threads:[~2011-07-09 21:04 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <BANLkTi==Y_MJ2H_u15DzunWusUb=GsotWg@mail.gmail.com>
2011-06-30 10:13 ` [PATCH] mxs-mmc: fix clock rate setting Koen Beel
2011-06-30 14:55   ` Wolfram Sang
2011-07-01  9:17     ` Wolfram Sang
2011-07-01 11:41       ` Sachin Nikam
2011-07-01 14:38         ` Sachin Nikam
2011-07-01 14:46           ` Wolfram Sang
2011-07-01 12:10       ` Koen Beel
2011-07-01 12:27         ` Wolfram Sang
2011-07-01 13:26           ` Koen Beel
2011-07-01 14:44             ` Wolfram Sang
2011-07-01 15:46               ` Shawn Guo
2011-07-02 13:12                 ` Wolfram Sang
2011-07-03  9:28                   ` Shawn Guo
2011-07-03 10:31                     ` Wolfram Sang
2011-07-03 11:54                       ` Shawn Guo
2011-07-04 10:34                         ` Wolfram Sang
2011-07-04 10:59                           ` Koen Beel
2011-07-06  9:38                             ` Wolfram Sang
2011-07-06  9:53                               ` Koen Beel
2011-07-06  9:58                                 ` Wolfram Sang
2011-07-04 10:37                         ` Koen Beel
2011-07-04 11:01               ` Koen Beel
2011-07-06  9:26                 ` Wolfram Sang
2011-07-09 21:04   ` Chris Ball [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2ei1zkvx4.fsf@bob.laptop.org \
    --to=cjb@laptop.org \
    --cc=koen.beel.barco@gmail.com \
    --cc=linux-mmc@vger.kernel.org \
    --cc=shawn.guo@freescale.com \
    --cc=w.sang@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox