Re: [PATCH] mxs-mmc: fix clock rate setting

Koen Beel
2011-07-04T11:01:11Z

On Fri, Jul 1, 2011 at 4:44 PM, Wolfram Sang <w.sang@pengutronix.de> wrote:
> Hi,
>
> On Fri, Jul 01, 2011 at 03:26:39PM +0200, Koen Beel wrote:
>> I send the patch as attachment for now.
>
> Fine with me in this case...
>
>> But I'll have to look into another way of doing this. Corporate mail
>> system is adding stupid disclaimers, gmail web ui is not working ok
>> and corporate firewalls avoid using a different smtp server...
>
> Good luck with that!
>
> About the patch itself: I didn't verify the formulas, but it does solve one
> special problem here. Thanks a lot! So:

Does it solve any other special problem except for the wrong clock rate setting?

>
> Tested-by: Wolfram Sang <w.sang@pengutronix.de>
>
> @chris: If Shawn also likes the patch, I think this is a stable candidate.
>
> Very minor nits:
>
>> From ab610437fade5b30fdeacd9e959ddf95bc42587a Mon Sep 17 00:00:00 2001
>> From: Koen Beel <koen.beel@barco.com>
>> Date: Thu, 30 Jun 2011 12:00:19 +0200
>> Subject: [PATCH] mxs-mmc: fix clock rate setting
>>
>> Fix clock rate setting on mxs-mmc driver.
>> Previously, if div2 was zero the value for TIMING_CLOCK_RATE would have been 255 instead of 0.
>> Also the limits for div1 (TIMING_CLOCK_DIVIDE) and div2 (TIMING_CLOCK_RATE + 1) where not correctly defined.
>>
>> Can easily be reproduced on mx23evk: default clock for high speed sdio cards is 50 MHz.
>> With a SSP_CLK of 28.8 MHz (default), this resulted in an actual clock rate of about 56 kHz.
>
> Commit msg should linebreak at 72.
>
>
>> Signed-off-by: Koen beel <koen.beel@barco.com>
>
> Capital 'B'?

Indeed, it should have been:
"Signed-off-by: Koen Beel <koen.beel@barco.com>"

>
> Regards,
>
>   Wolfram
>
> --
> Pengutronix e.K.                           | Wolfram Sang                |
> Industrial Linux Solutions                 | http://www.pengutronix.de/  |
>