public inbox for linux-mmc@vger.kernel.org
 help / color / mirror / Atom feed
From: Chris Ball <cjb@laptop.org>
To: Seungwon Jeon <tgih.jun@samsung.com>
Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mmc: dw_mmc: Fix DDR mode support.
Date: Thu, 11 Aug 2011 17:38:49 -0400	[thread overview]
Message-ID: <m2fwl7pr12.fsf@bob.laptop.org> (raw)
In-Reply-To: <1312515303-17169-1-git-send-email-tgih.jun@samsung.com> (Seungwon Jeon's message of "Fri, 5 Aug 2011 12:35:03 +0900")

Hi,

On Thu, Aug 04 2011, Seungwon Jeon wrote:
> Host driver can't get a hint of DDR mode through ios->ddr flag anymore.
> ios->timing is currently used to inform DDR mode as a substitute.
> And capability of MMC_CAP_MMC_HIGHSPEED is added for DDR support.
>
> Signed-off-by: Seungwon Jeon <tgih.jun@samsung.com>
> ---
>  drivers/mmc/host/dw_mmc.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
> index d65511e..b412a1d 100644
> --- a/drivers/mmc/host/dw_mmc.c
> +++ b/drivers/mmc/host/dw_mmc.c
> @@ -699,7 +699,7 @@ static void dw_mci_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
>  	}
>  
>  	/* DDR mode set */
> -	if (ios->ddr) {
> +	if (ios->timing == MMC_TIMING_UHS_DDR50) {
>  		regs = mci_readl(slot->host, UHS_REG);
>  		regs |= (0x1 << slot->id) << 16;
>  		mci_writel(slot->host, UHS_REG, regs);
> @@ -1646,7 +1646,7 @@ static int __init dw_mci_init_slot(struct dw_mci *host, unsigned int id)
>  			mmc->caps |= MMC_CAP_4_BIT_DATA;
>  
>  	if (host->pdata->quirks & DW_MCI_QUIRK_HIGHSPEED)
> -		mmc->caps |= MMC_CAP_SD_HIGHSPEED;
> +		mmc->caps |= MMC_CAP_SD_HIGHSPEED | MMC_CAP_MMC_HIGHSPEED;
>  
>  #ifdef CONFIG_MMC_DW_IDMAC
>  	mmc->max_segs = host->ring_size;

Thanks, pushed to mmc-next for 3.1 with Will's ACK.

- Chris.
-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child

      parent reply	other threads:[~2011-08-11 21:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-05  3:35 [PATCH] mmc: dw_mmc: Fix DDR mode support Seungwon Jeon
2011-08-05 10:20 ` Will Newton
2011-08-05 21:35   ` Jae hoon Chung
2011-08-08  1:38     ` Seungwon Jeon
2011-08-11 21:38 ` Chris Ball [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2fwl7pr12.fsf@bob.laptop.org \
    --to=cjb@laptop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=tgih.jun@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox