From: Chris Ball <cjb@laptop.org>
To: Aaron Lu <Aaron.Lu@amd.com>
Cc: Arindam Nath <arindam.nath@amd.com>, linux-mmc@vger.kernel.org
Subject: Re: [PATCH] mmc: sdhci: fix retuning timer wrongly deleted in sdhci_tasklet_finish
Date: Thu, 28 Jul 2011 18:28:13 -0400 [thread overview]
Message-ID: <m2fwlqjb0i.fsf@bob.laptop.org> (raw)
In-Reply-To: <1310362031-8186-1-git-send-email-Aaron.Lu@amd.com> (Aaron Lu's message of "Mon, 11 Jul 2011 13:27:11 +0800")
Hi Aaron,
On Mon, Jul 11 2011, Aaron Lu wrote:
> Currently, the retuning timer for retuning mode 1 will be deleted in
> function sdhci_tasklet_finish after a mmc request done, which will make
> retuning timing never trigger again. This patch fixed this problem.
>
> Signed-off-by: Aaron Lu <Aaron.Lu@amd.com>
> ---
> drivers/mmc/host/sdhci.c | 3 ---
> 1 files changed, 0 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
> index 91d9892..6250bac 100644
> --- a/drivers/mmc/host/sdhci.c
> +++ b/drivers/mmc/host/sdhci.c
> @@ -1863,9 +1863,6 @@ static void sdhci_tasklet_finish(unsigned long param)
>
> del_timer(&host->timer);
>
> - if (host->version >= SDHCI_SPEC_300)
> - del_timer(&host->tuning_timer);
> -
> mrq = host->mrq;
>
> /*
Pushed to mmc-next for 3.1 with Philip's Reviewed-by, thanks.
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
prev parent reply other threads:[~2011-07-28 22:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-11 5:27 [PATCH] mmc: sdhci: fix retuning timer wrongly deleted in sdhci_tasklet_finish Aaron Lu
2011-07-15 6:51 ` Nath, Arindam
2011-07-21 5:23 ` Aaron Lu
2011-07-21 9:35 ` zhangfei gao
2011-07-21 10:03 ` Aaron Lu
2011-07-21 20:27 ` Philip Rakity
2011-07-22 0:58 ` Aaron Lu
2011-07-22 10:21 ` zhangfei gao
2011-07-27 9:15 ` Aaron Lu
2011-07-27 14:56 ` Philip Rakity
2011-07-28 22:28 ` Chris Ball [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2fwlqjb0i.fsf@bob.laptop.org \
--to=cjb@laptop.org \
--cc=Aaron.Lu@amd.com \
--cc=arindam.nath@amd.com \
--cc=linux-mmc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox