Re: [PATCH V8] mmc: core: Add Power Off Notify Feature eMMC 4.5

Girish K S
2011-10-17T14:31:11Z

On 17 October 2011 18:17, Chris Ball <cjb@laptop.org> wrote:
> Hi Girish,
>
> On Mon, Oct 17 2011, Girish K S wrote:
>>>> + if (card != NULL && mmc_card_mmc(card) &&
>>>
>>> != NULL is unnecessary.
>>
>> This is required. Let me explain the scenario where i felt it is necessary.
>
> I'm not saying that you shouldn't test whether card is NULL -- I'm
> saying that "if (card && mmc_card_mmc(card) && " would perform this
> test with fewer characters, and be idiomatic for the kernel.
>
After fetching your mmc-next branch. i can see that this patch is
already applied. How about the changes that have been pointed here?

> Thanks,
>
> - Chris.
> --
> Chris Ball   <cjb@laptop.org>   <http://printf.net/>
> One Laptop Per Child
>