public inbox for linux-mmc@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] sdhci: pxav3 controller needs 32 bit ADMA addressing
@ 2011-07-11 21:47 Philip Rakity
  2011-07-14  1:48 ` zhangfei gao
  2011-07-28 22:27 ` Chris Ball
  0 siblings, 2 replies; 3+ messages in thread
From: Philip Rakity @ 2011-07-11 21:47 UTC (permalink / raw)
  To: linux-mmc@vger.kernel.org; +Cc: Zhangfei Gao


enable the quirk.

Best used in conjunction with patch downgrading
ADMA to SDMA when transfer is not aligned.

Signed-off-by: Philip Rakity <prakity@marvell.com>
---
 drivers/mmc/host/sdhci-pxav3.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/mmc/host/sdhci-pxav3.c b/drivers/mmc/host/sdhci-pxav3.c
index 4198dbb..fc7e4a5 100644
--- a/drivers/mmc/host/sdhci-pxav3.c
+++ b/drivers/mmc/host/sdhci-pxav3.c
@@ -195,7 +195,8 @@ static int __devinit sdhci_pxav3_probe(struct platform_device *pdev)
 	clk_enable(clk);
 
 	host->quirks = SDHCI_QUIRK_BROKEN_TIMEOUT_VAL
-		| SDHCI_QUIRK_NO_ENDATTR_IN_NOPDESC;
+		| SDHCI_QUIRK_NO_ENDATTR_IN_NOPDESC
+		| SDHCI_QUIRK_32BIT_ADMA_SIZE;
 
 	/* enable 1/8V DDR capable */
 	host->mmc->caps |= MMC_CAP_1_8V_DDR;
-- 
1.7.0.4



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] sdhci: pxav3 controller needs 32 bit ADMA addressing
  2011-07-11 21:47 [PATCH] sdhci: pxav3 controller needs 32 bit ADMA addressing Philip Rakity
@ 2011-07-14  1:48 ` zhangfei gao
  2011-07-28 22:27 ` Chris Ball
  1 sibling, 0 replies; 3+ messages in thread
From: zhangfei gao @ 2011-07-14  1:48 UTC (permalink / raw)
  To: Philip Rakity; +Cc: linux-mmc@vger.kernel.org, Zhangfei Gao

On Tue, Jul 12, 2011 at 5:47 AM, Philip Rakity <prakity@marvell.com> wrote:
>
> enable the quirk.
>
> Best used in conjunction with patch downgrading
> ADMA to SDMA when transfer is not aligned.
>
> Signed-off-by: Philip Rakity <prakity@marvell.com>
> ---
>  drivers/mmc/host/sdhci-pxav3.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-pxav3.c b/drivers/mmc/host/sdhci-pxav3.c
> index 4198dbb..fc7e4a5 100644
> --- a/drivers/mmc/host/sdhci-pxav3.c
> +++ b/drivers/mmc/host/sdhci-pxav3.c
> @@ -195,7 +195,8 @@ static int __devinit sdhci_pxav3_probe(struct platform_device *pdev)
>        clk_enable(clk);
>
>        host->quirks = SDHCI_QUIRK_BROKEN_TIMEOUT_VAL
> -               | SDHCI_QUIRK_NO_ENDATTR_IN_NOPDESC;
> +               | SDHCI_QUIRK_NO_ENDATTR_IN_NOPDESC
> +               | SDHCI_QUIRK_32BIT_ADMA_SIZE;
>
>        /* enable 1/8V DDR capable */
>        host->mmc->caps |= MMC_CAP_1_8V_DDR;
> --
> 1.7.0.4
>
>

Acked-by:  Zhangfei Gao <zhangfei.gao@marvell.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] sdhci: pxav3 controller needs 32 bit ADMA addressing
  2011-07-11 21:47 [PATCH] sdhci: pxav3 controller needs 32 bit ADMA addressing Philip Rakity
  2011-07-14  1:48 ` zhangfei gao
@ 2011-07-28 22:27 ` Chris Ball
  1 sibling, 0 replies; 3+ messages in thread
From: Chris Ball @ 2011-07-28 22:27 UTC (permalink / raw)
  To: Philip Rakity; +Cc: linux-mmc@vger.kernel.org, Zhangfei Gao

Hi Philip,

On Mon, Jul 11 2011, Philip Rakity wrote:
> enable the quirk.
>
> Best used in conjunction with patch downgrading
> ADMA to SDMA when transfer is not aligned.
>
> Signed-off-by: Philip Rakity <prakity@marvell.com>
> ---
>  drivers/mmc/host/sdhci-pxav3.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-pxav3.c b/drivers/mmc/host/sdhci-pxav3.c
> index 4198dbb..fc7e4a5 100644
> --- a/drivers/mmc/host/sdhci-pxav3.c
> +++ b/drivers/mmc/host/sdhci-pxav3.c
> @@ -195,7 +195,8 @@ static int __devinit sdhci_pxav3_probe(struct platform_device *pdev)
>  	clk_enable(clk);
>  
>  	host->quirks = SDHCI_QUIRK_BROKEN_TIMEOUT_VAL
> -		| SDHCI_QUIRK_NO_ENDATTR_IN_NOPDESC;
> +		| SDHCI_QUIRK_NO_ENDATTR_IN_NOPDESC
> +		| SDHCI_QUIRK_32BIT_ADMA_SIZE;
>  
>  	/* enable 1/8V DDR capable */
>  	host->mmc->caps |= MMC_CAP_1_8V_DDR;

Pushed to mmc-next for 3.1 with Zhangfei's ACK, thanks.

- Chris.
-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2011-07-28 22:27 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-07-11 21:47 [PATCH] sdhci: pxav3 controller needs 32 bit ADMA addressing Philip Rakity
2011-07-14  1:48 ` zhangfei gao
2011-07-28 22:27 ` Chris Ball

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox