public inbox for linux-mmc@vger.kernel.org
 help / color / mirror / Atom feed
From: Chris Ball <cjb@laptop.org>
To: Shashidhar Hiremath <shashidharh@vayavyalabs.com>
Cc: Jaehoon Chung <jh80.chung@samsung.com>,
	Shawn Guo <shawn.guo@linaro.org>,
	Wolfram Sang <w.sang@pengutronix.de>,
	Philip Rakity <prakity@marvell.com>,
	Zhangfei Gao <zhangfei.gao@marvell.com>,
	Will Newton <will.newton@imgtec.com>,
	James Hogan <james.hogan@imgtec.com>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	Matt Fleming <matt@console-pimps.org>,
	linux-mmc@vger.kernel.org
Subject: Re: [PATCH 1/1] [PATCH v4 1/1] mmc: Support of DUAL BUFFER DESC[ring] mode for dw_mmc
Date: Thu, 03 Nov 2011 08:35:33 -0400	[thread overview]
Message-ID: <m2obwt8ju2.fsf@bob.laptop.org> (raw)
In-Reply-To: <CANYdXnpe0prpdJcYpi3yVqCecugwZ1999c2u2u6ffjXjSeCDnw@mail.gmail.com> (Shashidhar Hiremath's message of "Thu, 3 Nov 2011 17:17:06 +0530")

Hi,

On Thu, Nov 03 2011, Shashidhar Hiremath wrote:
> Hi Chris,
>   Can this patch be accepted by criteria that its an additional
> feature supported by the hardware and hence good to have the support
> in the driver.Also note the patch has been tested.

I think Will and James should make the call on that.

My own opinion is that it's not usually a good idea to merge code that
increases complexity for no performance gain; if the feature is actually
important, someone should find a way to finish it and measure a
performance gain (the gain can be in any of bandwidth, memory, or
lower CPU utilization) with it, to prove that the change is worthwhile.

Thanks,

- Chris.
-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child

  reply	other threads:[~2011-11-03 12:35 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-27 11:39 [PATCH 1/1] [PATCH v4 1/1] mmc: Support of DUAL BUFFER DESC[ring] mode for dw_mmc Shashidhar Hiremath
2011-10-05  2:14 ` Jaehoon Chung
2011-10-05  4:54   ` Shashidhar Hiremath
2011-10-05  5:07     ` Jaehoon Chung
2011-11-03 11:47   ` Shashidhar Hiremath
2011-11-03 12:35     ` Chris Ball [this message]
2011-11-03 15:18       ` Will Newton
2011-11-04  1:43         ` Jaehoon Chung
2011-11-04  7:06         ` Shashidhar Hiremath
2011-11-14 16:02           ` Shashidhar Hiremath
2011-11-19  1:34             ` James Hogan
2012-01-11 11:27               ` Shashidhar Hiremath
2012-01-17 13:46                 ` Shashidhar Hiremath
2012-01-19 10:29                   ` Will Newton
2012-01-19 10:34                     ` Shashidhar Hiremath
2012-04-12  5:01                     ` Shashidhar Hiremath

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2obwt8ju2.fsf@bob.laptop.org \
    --to=cjb@laptop.org \
    --cc=james.hogan@imgtec.com \
    --cc=jh80.chung@samsung.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-mmc@vger.kernel.org \
    --cc=matt@console-pimps.org \
    --cc=prakity@marvell.com \
    --cc=shashidharh@vayavyalabs.com \
    --cc=shawn.guo@linaro.org \
    --cc=w.sang@pengutronix.de \
    --cc=will.newton@imgtec.com \
    --cc=zhangfei.gao@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox