From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Ball Subject: Re: [PATCH 1/1] [PATCH v4 1/1] mmc: Support of DUAL BUFFER DESC[ring] mode for dw_mmc Date: Thu, 03 Nov 2011 08:35:33 -0400 Message-ID: References: <1317123568-5203-1-git-send-email-shashidharh@vayavyalabs.com> <4E8BBD76.9020001@samsung.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from void.printf.net ([89.145.121.20]:47826 "EHLO void.printf.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933538Ab1KCMfx (ORCPT ); Thu, 3 Nov 2011 08:35:53 -0400 In-Reply-To: (Shashidhar Hiremath's message of "Thu, 3 Nov 2011 17:17:06 +0530") Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Shashidhar Hiremath Cc: Jaehoon Chung , Shawn Guo , Wolfram Sang , Philip Rakity , Zhangfei Gao , Will Newton , James Hogan , Kyungmin Park , Matt Fleming , linux-mmc@vger.kernel.org Hi, On Thu, Nov 03 2011, Shashidhar Hiremath wrote: > Hi Chris, > Can this patch be accepted by criteria that its an additional > feature supported by the hardware and hence good to have the support > in the driver.Also note the patch has been tested. I think Will and James should make the call on that. My own opinion is that it's not usually a good idea to merge code that increases complexity for no performance gain; if the feature is actually important, someone should find a way to finish it and measure a performance gain (the gain can be in any of bandwidth, memory, or lower CPU utilization) with it, to prove that the change is worthwhile. Thanks, - Chris. -- Chris Ball One Laptop Per Child