From: Chris Ball <cjb@laptop.org>
To: Ulf Hansson <ulf.hansson@stericsson.com>
Cc: linux-mmc@vger.kernel.org, Per Forlin <per.forlin@stericsson.com>,
Lee Jones <lee.jones@linaro.org>,
Stefan Nilsson XK <stefan.xk.nilsson@stericsson.com>
Subject: Re: [PATCH] mmc: core: Set correct bus mode before card init
Date: Wed, 21 Sep 2011 14:20:09 -0400 [thread overview]
Message-ID: <m2vcsl3gh2.fsf@bob.laptop.org> (raw)
In-Reply-To: <1316101838-22660-1-git-send-email-ulf.hansson@stericsson.com> (Ulf Hansson's message of "Thu, 15 Sep 2011 17:50:38 +0200")
Hi,
On Thu, Sep 15 2011, Ulf Hansson wrote:
> From: Stefan Nilsson XK <stefan.xk.nilsson@stericsson.com>
>
> Earlier all cards where initiated with bus mode set as OPENDRAIN, and then
> later switched to PUSHPULL. According to the MMC/SD/SDIO specifications only
> MMC cards use OPENDRAIN during init. For both SD and SDIO the bus mode shall
> be PUSHPULL before attempting to init the card.
>
> The consequence of having incorrect bus mode can lead to not being able
> to detect the card. Therefore the default behavior have now been changed to
> PUSHPULL in mmc_power_up, and will only be temporarily switched when trying
> to attach or init a MMC card.
>
> Signed-off-by: Stefan Nilsson XK <stefan.xk.nilsson@stericsson.com>
> Signed-off-by: Ulf HANSSON <ulf.hansson@stericsson.com>
Thanks, pushed to mmc-next for 3.2 with Linus W's ACK.
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
prev parent reply other threads:[~2011-09-21 18:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-15 15:50 [PATCH] mmc: core: Set correct bus mode before card init Ulf Hansson
2011-09-16 2:05 ` Aaron Lu
2011-09-16 6:57 ` Stefan Nilsson XK
2011-09-20 6:48 ` Linus Walleij
2011-09-21 18:20 ` Chris Ball [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2vcsl3gh2.fsf@bob.laptop.org \
--to=cjb@laptop.org \
--cc=lee.jones@linaro.org \
--cc=linux-mmc@vger.kernel.org \
--cc=per.forlin@stericsson.com \
--cc=stefan.xk.nilsson@stericsson.com \
--cc=ulf.hansson@stericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox