From: Chris Ball <cjb@laptop.org>
To: Girish K S <girish.shivananjappa@linaro.org>
Cc: linux-mmc@vger.kernel.org, kgene.kim@samsung.com,
patches@linaro.org, linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH RESEND V1] mmc: replace printk with appropriate display macro
Date: Tue, 11 Oct 2011 10:11:26 -0400 [thread overview]
Message-ID: <m2y5wrk48h.fsf@bob.laptop.org> (raw)
In-Reply-To: <1318313649-22465-1-git-send-email-girish.shivananjappa@linaro.org> (Girish K. S.'s message of "Tue, 11 Oct 2011 11:44:09 +0530")
Hi,
On Tue, Oct 11 2011, Girish K S wrote:
> All the files using printk function for displaying kernel messages
> in the mmc driver have been replaced with corresponding macro.
Thanks, applied!
I haven't been sure how to handle this patch; in general cosmetic
patches that touch many parts of many files are a bad idea, because they
break the ability to merge patches. Since we're getting near the end of
merging the 3.2 merge window patches, though, maybe now is a good time.
If this patch starts causing merge conflicts, I might pull it out later
or remove the modifications for the most common files (core.c/sd.c/sdhci.c).
Thanks,
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
prev parent reply other threads:[~2011-10-11 14:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-11 6:14 [PATCH RESEND V1] mmc: replace printk with appropriate display macro Girish K S
2011-10-11 14:11 ` Chris Ball [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2y5wrk48h.fsf@bob.laptop.org \
--to=cjb@laptop.org \
--cc=girish.shivananjappa@linaro.org \
--cc=kgene.kim@samsung.com \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=patches@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox