From: Chris Ball <cjb@laptop.org>
To: Sourav Poddar <sourav.poddar@ti.com>
Cc: linux-mmc@vger.kernel.org, tony@atomide.com, madhu.cr@ti.com,
kishore.kadiyala@ti.com, gadiyar@ti.com
Subject: Re: [PATCH v2] omap: hsmmc: fix ocr mask usage
Date: Sat, 18 Jun 2011 23:18:32 -0400 [thread overview]
Message-ID: <m2y60yzeyf.fsf@bob.laptop.org> (raw)
In-Reply-To: <1308047399-8537-1-git-send-email-sourav.poddar@ti.com> (Sourav Poddar's message of "Tue, 14 Jun 2011 15:59:59 +0530")
Hi,
On Tue, Jun 14 2011, Sourav Poddar wrote:
> From: Anand Gadiyar <gadiyar@ti.com>
>
> The OMAP HSMMC driver uses an ocr_mask to determine the
> list of voltages supported by the card. It populates this
> mask based on the list of voltages supported by the
> regulator that supplies the voltage.
>
> Commit 64be97822b (omap4 hsmmc: Update ocr mask for MMC2 for
> regulator to use) passed a fixed ocr_mask from the OMAP4 SDP
> board file to limit the voltage to 2.9-3.0 Volts, and updated
> the driver to use this mask if provided, instead of using the
> regulator's supported voltages.
>
> However the commit is buggy - the ocr_mask is overridden
> by the regulator's capabilities anyway. Fix this.
>
> (The bug shows up when a system-wide suspend is attempted
> on the OMAP4 SDP/Blaze platforms. The eMMC card comes up
> at 3V, but drops to 1.65V after the system resumes).
>
> Signed-off-by: Anand Gadiyar <gadiyar@ti.com>
> Acked-by: Balaji T K <balajitk@ti.com>
> Tested-by: Kishore Kadiyala <kishore.kadiyala@ti.com>
> Signed-off-by: Sourav Poddar <sourav.poddar@ti.com>
Pushed to mmc-next for 3.0-rc with Venkat's ACK, thanks.
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
prev parent reply other threads:[~2011-06-19 3:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-14 10:29 [PATCH v2] omap: hsmmc: fix ocr mask usage Sourav Poddar
2011-06-16 11:15 ` S, Venkatraman
2011-06-19 3:18 ` Chris Ball [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2y60yzeyf.fsf@bob.laptop.org \
--to=cjb@laptop.org \
--cc=gadiyar@ti.com \
--cc=kishore.kadiyala@ti.com \
--cc=linux-mmc@vger.kernel.org \
--cc=madhu.cr@ti.com \
--cc=sourav.poddar@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox