From: Chris Ball <cjb@laptop.org>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: linux-mmc@vger.kernel.org
Subject: Re: [PATCH] mmc: sdhci: Test cd-gpio instead of SDHCI presence when probing
Date: Mon, 17 Sep 2012 06:08:13 -0400 [thread overview]
Message-ID: <m31ui1ynaq.fsf@pullcord.laptop.org> (raw)
In-Reply-To: <Pine.LNX.4.64.1209171107130.1689@axis700.grange> (Guennadi Liakhovetski's message of "Mon, 17 Sep 2012 11:09:38 +0200 (CEST)")
Hi,
On Mon, Sep 17 2012, Guennadi Liakhovetski wrote:
> On Mon, 17 Sep 2012, Chris Ball wrote:
>
>> From: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
>>
>> Previously to this patch, an SDHCI platform that uses a GPIO for
>> card detection instead of the internal SDHCI_CARD_PRESENT bit on
>> the presence register would fail to bring up a new card because
>> logic in sdhci_request() fails the request if that bit is 0.
>>
>> Some drivers worked around this in various ways: esdhc-imx defines
>> an IO accessor to fake the presence bit being true, s3c turns on
>> polling (which stops the SDHCI driver from checking the bit) after
>> a card's inserted. But none of this should be necessary; the real
>> fix is to check whether we're using a GPIO and avoid relying on
>> the presence bit if so, as this patch implements.
>>
>
> Well, ok, thanks for attributing this patch to me:-) I guess then my Sob
> should go in the first, as you'll be forwarding the patch upstream? But
> feel free to swap them if you disagree
>
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Yes, I'll put yours in first. Pushed to mmc-next for 3.7; thanks!
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
prev parent reply other threads:[~2012-09-17 10:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-17 6:29 cd-gpio and SDHCI presence Chris Ball
2012-09-17 7:28 ` Guennadi Liakhovetski
2012-09-17 8:45 ` Chris Ball
2012-09-17 8:55 ` [PATCH] mmc: sdhci: Test cd-gpio instead of SDHCI presence when probing Chris Ball
2012-09-17 9:09 ` Guennadi Liakhovetski
2012-09-17 10:08 ` Chris Ball [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m31ui1ynaq.fsf@pullcord.laptop.org \
--to=cjb@laptop.org \
--cc=g.liakhovetski@gmx.de \
--cc=linux-mmc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox